Skip to content

Conversation

@ajtudela
Copy link

@ajtudela ajtudela commented Apr 8, 2025

I am opening this PR as you mentioned in Nav2#4957.

I have added a failing test for JSON conversions of std::vector. The test fails in this line:

auto poses2 = exporter.fromJson(json["poses"])->first.cast<std::vector<TestTypes::Pose3D>>();

with this error

nonstd::expected_lite::expected<T, E>::value_type* nonstd::expected_lite::expected<T, E>::operator->() [with T = std::pair<BT::Any, BT::TypeInfo>; E = std::__cxx11::basic_string<char>; value_type = std::pair<BT::Any, BT::TypeInfo>]: Assertion `has_value()' failed.

I'm not entirely sure but, this may be related to Groot2#55

ajtudela added 3 commits April 8, 2025 11:01
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
@facontidavide
Copy link
Collaborator

This PR will include and extend the test and fix the issue. #965

Additionally, user will not need to register vector of type anymore

@ajtudela ajtudela deleted the vector branch April 17, 2025 19:15
@ajtudela
Copy link
Author

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants