DataSourceScriptDatabaseInitializer may still try to access the database even though its initialization mode is never #28931

Activity

1. wilkinsona

   added

   type: bugA general bugA general bug

   on Dec 8, 2021
2. wilkinsona

   added this to the 2.5.x milestone on Dec 8, 2021
3. snicoll commented on Dec 13, 2021

   

   snicoll

   on Dec 13, 2021

   Member

   More actions

   I am looking at this issue and I am not able to reproduce the problem in a unit test. I can see the isEnabled check inconsistency with AbstractDataSourceInitializer but I fail to see where the DataSource would be accessed to resolve the scripts. AbstractScriptDatabaseInitializer does not have @@platform@@ support as far as I can see...

   I can move the check to make it more consistent but I'd like someone else to have a look in case I missed something.
4. snicoll

   self-assigned this

   on Dec 13, 2021
5. snicoll

   added

   for: team-attentionAn issue we'd like other members of the team to reviewAn issue we'd like other members of the team to review

   and removed

   for: team-attentionAn issue we'd like other members of the team to reviewAn issue we'd like other members of the team to review

   on Dec 13, 2021
6. snicoll

   modified the milestones: 2.5.x, 2.6.2 on Dec 14, 2021
7. snicoll

   changed the title [-]AbstractScriptDatabaseInitializer may still try to access the database even though its initialization mode is never[/-] on Dec 14, 2021
8. snicoll commented on Dec 14, 2021

   

   snicoll

   on Dec 14, 2021

   Last edited by snicoll

   Member

   More actions

   I think 2.5.x is fine and the regression is in 2.6.x where we use DataSourceScriptDatabaseInitializer and its settings are computed upfront. I'll edit the title of the issue accordingly.
9. snicoll

   closed this as completedin 55859eaon Dec 16, 2021