Hibernate validation messages broken in spring boot 2.6.1 when setUseCodeAsDefaultMessage set to true #28930

Activity

1. spring-projects-issues

   added

   status: waiting-for-triageAn issue that has not yet been triaged. Contributions will not be accepted.An issue that has not yet been triaged. Contributions will not be accepted.

   on Dec 8, 2021
2. snicoll commented on Dec 8, 2021

   

   snicoll

   on Dec 8, 2021

   Last edited by snicoll

   Member

   More actions

   Thanks for the report. Spring Boot 2.6 switched to Hibernate Validator 7 and downgrading it to the version used by Spring Boot 2.5.x didn't fix the problem so we'll have to investigate.
3. wilkinsona commented on Dec 8, 2021

   

   wilkinsona

   on Dec 8, 2021

   Last edited by wilkinsona

   Member

   More actions

   Thanks for the sample, @runningonfumes. The change in behaviour is an unanticipated side-effect of #17530. You can restore the previous behaviour by defining your own validator:

   @Bean
   @Role(BeanDefinition.ROLE_INFRASTRUCTURE)
   public static LocalValidatorFactoryBean customValidator() {
       LocalValidatorFactoryBean factoryBean = new LocalValidatorFactoryBean();
       MessageInterpolatorFactory interpolatorFactory = new MessageInterpolatorFactory();
       factoryBean.setMessageInterpolator(interpolatorFactory.getObject());
       return factoryBean;
   }

   To make this easier, we could perhaps introduce a configuration property that allows you to opt out of using the MessageSource for validation message interpolation. Flagging for team attention so that we can consider our options.
4. wilkinsona

   added

   for: team-attentionAn issue we'd like other members of the team to reviewAn issue we'd like other members of the team to review

   on Dec 8, 2021
5. philwebb

   added

   type: regressionA regression from a previous releaseA regression from a previous release

   and removed

   for: team-attentionAn issue we'd like other members of the team to reviewAn issue we'd like other members of the team to review

   status: waiting-for-triageAn issue that has not yet been triaged. Contributions will not be accepted.An issue that has not yet been triaged. Contributions will not be accepted.

   on Dec 15, 2021
6. philwebb

   added this to the 2.6.x milestone on Dec 15, 2021
7. scottfrederick

   self-assigned this

   on Dec 15, 2021
8. scottfrederick

   added a commit that references this issue on Dec 16, 2021

   Fix message interpolation when code is used as default message

   ...

   This issue will close once commit 92b096a is merged into the 'main' branch.

   92b096a
9. scottfrederick

   closed this as completedin 92b096aon Dec 16, 2021
10. scottfrederick

    modified the milestones: 2.6.x, 2.6.2 on Dec 16, 2021