JavaScript onclick change href

Question

I can't figure out why this isn't working. It changes to the first link and wont keep going. I'd also need it to loop through so when you click it always circles through the links I have a php variable that is the last #panelNum.

<html>
<head>
<script language="JavaScript"><!--
function findLinkByHref(href) {
  for (var i=0; i<document.links.length; i++) {
    if (document.links[i].href == href) return i;
  }
  return -1;
}

function changeLinkHref(id,newHref,oldHref) {
  if (document.links.length > 0) {
    if (document.getElementById) {
      document.getElementById(id).href = newHref;
    }
    else if (document.all) {
      document.all[id].href = newHref;
    }
    else {
      var index = findLinkByHref(oldHref);
      if (index > -1)
        document.links[index].href = newHref;
    }
  }
}
//--></script>
</head>
<body>
<a id="myLink" href="#panel3" value="Change href" onClick="changeLinkHref('myLink','#panel4','#panel5','#panel5','#panel6')">somewhere</a>
</body>
</html>

Dan Heberden · Accepted Answer · 2010-06-22 21:07:31Z

function findLinkByHref(href) {
  for (var i=0; i<document.links.length; i++) {
    if (document.links[i].href == href) return i;
  }
}

if you return in an if, it still returns - thus stopping execution of your function.

This is the only for loop, thus the only place you are iterating through all of your links. It sounds like you want to do this in the changeLinkHref function, something like..

 else if (document.all) {
      document.all[id].href = newHref;
    }
    else {
      var index = findLinkByHref(oldHref);
      for (var i=0; i<document.links.length; i++) {
         // change all links?

Ben · Accepted Answer · 2014-07-16 00:27:18Z

0

You can do something like this.

JS

function A()    {
document.getElementById("B").href="http://empireminecraft.com/";
}

HTML

<button type="button" onClick="A()">Yo!</button>
<a href="https://duckduckgo.com/?q=web+validator" id="B">Yo!</a>

I just used URLs that I had open. For some reason, when I tried it, I could only get it to work in IE

answered Jul 16, 2014 at 0:27

Ben

2,24922 silver badges30 bronze badges

Collectives™ on Stack Overflow

JavaScript onclick change href

2 Answers 2

Comments

JS

HTML

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

JS

HTML

Comments

Related