window.location.href doesn't redirect

Question

I know this is a question much discussed but I can't figure out why it does not work for me.

This is my function:

function ShowComments(){

 alert("fired");
 var movieShareId = document.getElementById('movieId');
 //alert("found div" + movieShareId.textContent || movieShareId.innerText);
 //alert("redirect location: /comments.aspx?id=" + movieShareId.textContent || movieShareId.innerText + "/");
 window.location.href = "/comments.aspx?id=" + movieShareId.textContent || movieShareId.innerText + "/";
 var newLocation = window.location;
 //alert("full location: " + window.location);

}

If I have the alerts uncommented or if I have Mozilla's bugzilla open it works fine, otherwise it does not redirect to the other page.

Any ideas why?

What's the point of ` var newLocation = window.location;` ? No line should be executed after the window.location change. — Denys Séguret
– Denys Séguret, Commented Apr 2, 2013 at 8:06
How are you calling the function? Are you doing something else at that point that may interfer with the change of location? — Guffa
– Guffa, Commented Apr 2, 2013 at 8:08
Does this answer your question? How to prevent mailto event from opening a new tab in browser — Vega
– Vega, Commented Apr 2, 2023 at 17:33

RononDex · Accepted Answer · 2014-01-15 10:01:06Z

97

If you are calling this function through a submit button. This may be the reason why the browser does not redirect. It will run the code in the function and then submit the page instead of redirect. In this case change the type tag of your button.

edited Jan 15, 2014 at 10:01

RononDex

4,19527 silver badges40 bronze badges

answered Jan 15, 2014 at 9:41

Jose

9716 silver badges3 bronze badges

Sign up to request clarification or add additional context in comments.

10 Comments

richie Over a year ago

Thanks. Helped a lot. I had my button 'type' as 'submit'. Changed it to 'reset' and it worked.

MDaldoss Over a year ago

You absolutely made my day. 12h of google and stackoverflow searching for that. Top.

NecipAllef Over a year ago

Interestingly enough, even if my button was not submit, it didn't work cause it was inside a form. I had to move it outside then it worked.

Ryan Gibbs Over a year ago

This was my issue for a button that had NO type call out, putting type='button' fixed the issue. Thanks!

sleighty Over a year ago

To add here, if you still want to have button[type=submit] and handle the redirection in the form's submit event, you can also call event.preventDefault() in the event handler--setting window.location.href should then properly redirect.

|

Sruit A.Suk · Accepted Answer · 2017-12-06 08:35:41Z

37

From this answer,

window.location.href not working

you just need to add

return false;

at the bottom of your function

answered Dec 6, 2017 at 8:35

Sruit A.Suk

7,3137 gold badges65 silver badges74 bronze badges

2 Comments

Jeril Over a year ago

didnt work for me

WilliamK Over a year ago

Adding this destroyed the redirect.

Denys Séguret · Accepted Answer · 2018-08-09 04:56:51Z

9

Some parenthesis are missing.

Change

 window.location.href = "/comments.aspx?id=" + movieShareId.textContent || movieShareId.innerText + "/";

to

 window.location = "/comments.aspx?id=" + (movieShareId.textContent || movieShareId.innerText) + "/";

No priority is given to the || compared to the +.

Remove also everything after the window.location assignation : this code isn't supposed to be executed as the page changes.

Note: you don't need to set location.href. It's enough to just set location.

edited Aug 9, 2018 at 4:56

answered Apr 2, 2013 at 8:07

Denys Séguret

384k90 gold badges813 silver badges780 bronze badges

1 Comment

Denys Séguret Over a year ago

@user2235124 There are other problems in your page, I think. And the fact you have some code after the location assignment makes me suspect bigger logical problems. Can you build a fiddle showing your issue ?

Dmitry Shvedov · Accepted Answer · 2021-03-02 18:50:21Z

8

Solution from here: http://www.codeproject.com/Questions/727493/JavaScript-document-location-href-not-working

document.location.href = 'Your url',true;

edited Mar 2, 2021 at 18:50

Dmitry Shvedov

3,3244 gold badges41 silver badges57 bronze badges

answered Aug 24, 2016 at 7:10

komal thakkar

2191 gold badge3 silver badges7 bronze badges

Comments

Luis Gouveia · Accepted Answer · 2018-02-15 17:37:20Z

6

Make sure you're not sending a '#' at the end of your URL. In my case, that was preventing window.location.href from working.

answered Feb 15, 2018 at 17:37

Luis Gouveia

8,95510 gold badges51 silver badges74 bronze badges

2 Comments

Omar N Shamali Over a year ago

yea same here, isn't there any native overcome to the issue?

Gabe Over a year ago

Note, the redirect with a hash will work if you are including it before or without any querystring parameters.

Dmitry Shvedov · Accepted Answer · 2021-03-02 18:49:35Z

6

You can't use window.location.replace or document.location.href or any of your favourite vanilla javascript methods to redirect a page to itself.

So if you're dynamically adding in the redirect path from the back end, or pulling it from a data tag, make sure you do check at some stage for redirects to the current page. It could be as simple as:

if(window.location.href == linkout)
{
    location.reload();
}
else
{
    window.location.href = linkout;
}

edited Mar 2, 2021 at 18:49

Dmitry Shvedov

3,3244 gold badges41 silver badges57 bronze badges

answered May 27, 2019 at 7:56

Paulus

991 silver badge9 bronze badges

Comments

Ivijan Stefan Stipić · Accepted Answer · 2018-12-10 13:28:13Z

I'll give you one nice function for this problem:

function url_redirect(url){
    var X = setTimeout(function(){
        window.location.replace(url);
        return true;
    },300);

    if( window.location = url ){
        clearTimeout(X);
        return true;
    } else {
        if( window.location.href = url ){
            clearTimeout(X);
            return true;
        }else{
            clearTimeout(X);
            window.location.replace(url);
            return true;
        }
    }
    return false;
};

This is universal working solution for the window.location problem. Some browsers go into problem with window.location.href and also sometimes can happen that window.location fail. That's why we also use window.location.replace() for any case and timeout for the "last try".

Community · Accepted Answer · 2017-05-23 12:34:12Z

3

window.location.replace is the best way to emulate a redirect:

function ShowComments(){
    var movieShareId = document.getElementById('movieId');
    window.location.replace("/comments.aspx?id=" + (movieShareId.textContent || movieShareId.innerText) + "/");
}

More information about why window.location.replace is the best javascript redirect can be found right here.

edited May 23, 2017 at 12:34

CommunityBot

11 silver badge

answered Apr 2, 2013 at 8:07

Eldar

5913 silver badges16 bronze badges

1 Comment

Denys Séguret Over a year ago

The point made in the answer you link to is about the trace in history. I don't see how it's relevant.

starball · Accepted Answer · 2023-11-29 20:30:17Z

2

In my case it is working as expected for all browsers after setting time interval.

setTimeout(function(){document.location.href = "myNextPage.html";},100);

edited Nov 29, 2023 at 20:30

starball♦

59.6k53 gold badges315 silver badges1k bronze badges

answered Feb 3, 2020 at 14:05

Aijaj Hussain Ansari

3752 silver badges6 bronze badges

Comments

user12678669 · Accepted Answer · 2020-01-08 22:25:01Z

0

window.location.href wasn't working in Android. I cleared cache in Android Chrome and it works fine. Suggest trying this first before getting involved in various coding.

answered Jan 8, 2020 at 22:25

user12678669

1

Comments

Suraj Rao · Accepted Answer · 2023-02-19 03:20:10Z

0

Go to your api route, make sure you are not missing a response such as

res.status(200).json(data);

edited Feb 19, 2023 at 3:20

Suraj Rao

29.7k11 gold badges96 silver badges104 bronze badges

answered Feb 19, 2023 at 3:07

WhatsAVadim

1

1 Comment

Community Over a year ago

As it’s currently written, your answer is unclear. Please edit to add additional details that will help others understand how this addresses the question asked. You can find more information on how to write good answers in the help center.

Collectives™ on Stack Overflow

window.location.href doesn't redirect

11 Answers 11

10 Comments

2 Comments

1 Comment

Comments

2 Comments

Comments

Comments

1 Comment

Comments

Comments

1 Comment

Linked

Hot Network Questions

Collectives™ on Stack Overflow

11 Answers 11

10 Comments

2 Comments

1 Comment

Comments

2 Comments

Comments

Comments

1 Comment

Comments

Comments

1 Comment

Linked

Related