Passing variable to window.location href [duplicate]

Question

I'm trying to delay outgoing links when clicked, so that googles event tracking have time to occur.

I wrote the following code, but I'm unsure of how to pass my variable to window.location. It just adds it as string "url" and not the link adress. What am I doing wrong?

$("a.private-product-order-button").click(function(e) {
   e.preventDefault();
   _gaq.push(['_trackEvent', 'Order buttons', 'Click', 'Service']);
   var url = $(this).attr("href");
   setTimeout(function() {
      $(window.location).attr('href', 'url');
      }, 200);
});

window.location.href=url - you are over jQuerying it

mplungjan
– mplungjan

2013-02-13 09:37:19 +00:00
Commented Feb 13, 2013 at 9:37 — mplungjan
– mplungjan, Commented Feb 13, 2013 at 9:37
@mplungjan: Is such a thing even possible?

Blender
– Blender

2013-02-13 09:38:44 +00:00
Commented Feb 13, 2013 at 9:38 — Blender
– Blender, Commented Feb 13, 2013 at 9:38

dfsq · Accepted Answer · 2013-02-13 09:38:36Z

2

No need to use jQuery to set a property of the location object (and no need to use jQuery to get href property of the anchor object):

$("a.private-product-order-button").click(function(e) {
    e.preventDefault();
    _gaq.push(['_trackEvent', 'Order buttons', 'Click', 'Service']);

    var url = this.href;
    setTimeout(function() {
        window.location.href = url;
    }, 200);
});

answered Feb 13, 2013 at 9:38

dfsq

193k26 gold badges244 silver badges261 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Johan Dahl Over a year ago

Thank's. I'm so new to this, doing things the "right way" is a work in progress.

kidwon · Accepted Answer · 2013-02-13 09:37:09Z

1

Because you're adding string after all.

It should be:

$(window.location).attr('href', url);

not

$(window.location).attr('href', 'url');

answered Feb 13, 2013 at 9:37

kidwon

4,5325 gold badges31 silver badges46 bronze badges

1 Comment

Johan Dahl Over a year ago

Ohh damnit it was so easy. Thanks.

Jerry Joseph · Accepted Answer · 2013-02-13 09:38:40Z

1

Use $(window.location).attr('href', url); without the quotes around url.

answered Feb 13, 2013 at 9:38

Jerry Joseph

1,0228 silver badges14 bronze badges

Collectives™ on Stack Overflow

Passing variable to window.location href [duplicate]

3 Answers 3

1 Comment

1 Comment

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

Comments

Linked

Related