Skip to content

Conversation

@TheJulianJES
Copy link
Contributor

Proposed change

Works around an issue introduced by download-artifact to v5, where download behavior is different depending on how many artifacts are downloaded. Now, a directory isn't created for a single artifact, but only done for multiple ones.

To work around that, we now always download the coverage artifacts in a coverage directory, which we then scan using find for all coverage reports. This isn't elegant, but should be fine for our use-case.

Additional information

For us, this was introduced by:

More background complaints on this change:

- name: Download all coverage artifacts
uses: actions/download-artifact@v7
with:
pattern: coverage-*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pattern change isn't really relevant for this PR, but I've included it anyway.
We only upload coverage artifacts at the moment, but I think it's nice to make sure we explicitly only download coverage artifacts here, and nothing else. E.g. coverage-3.11.14 and coverage-3.12.12

Copy link
Contributor Author

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this for now to unbreak some things. This was tested with a matrix with multiple Python versions and on one with just one Python version.

IMO, this is a really bad decision on the download-artifact, especially since there isn't an easy workaround.

All other workarounds that I saw were more complex than this, but we get away with this, as we don't need to care about the exact paths the coverage reports are saved in. We just need the files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant