Skip to content

assert: deprecate CompareType #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 19, 2024
Merged

assert: deprecate CompareType #1566

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a712990
assert: refactor Test_compareTwoValuesCorrectCompareResult
dolmen Mar 4, 2024
74e1cbe
assert: minor refactor of compareTwoValues tests
dolmen Mar 4, 2024
39442a4
assert: drop CompareType
dolmen Mar 5, 2024
a155d2a
assert: restore CompareType, but mark it as deprecated
dolmen Mar 4, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
assert: restore CompareType, but mark it as deprecated 
Reinstate CompareType for full backward compatibility, but mark it as
deprecated.
  • Loading branch information
@dolmen
dolmen committed Mar 19, 2024
commit a155d2a49d0cb5176c66f9af7313809b506ebea9
3 changes: 3 additions & 0 deletions assert/assertion_compare.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ import (
"time"
)

// Deprecated: CompareType has only ever been for internal use and has accidently been published since v1.6.0. Do not use it.
type CompareType = compareResult

type compareResult int

const (
Expand Down