Skip to content

Conversation

@Sidnioulz
Copy link
Member

@Sidnioulz Sidnioulz commented Jan 19, 2026

What I did

Fixed a regression:

Peek.2026-01-19.18-09.webm

Checklist for Contributors

Testing

Manual testing

  1. Type stuff in search
  2. Click on a result
  3. Notice that sidebar explorer gets rendered again

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Bug Fixes
    • Improved sidebar search navigation behavior to better handle menu state interactions, ensuring search results remain properly accessible whether the menu is open or closed.

✏️ Tip: You can customize this high-level summary in your review settings.

@nx-cloud
Copy link

nx-cloud bot commented Jan 19, 2026

View your CI Pipeline Execution ↗ for commit d9cbbcb

Command Status Duration Result
nx run-many -t compile,check,knip,test,pretty-d... ✅ Succeeded 9m 4s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-19 17:22:00 UTC

@nx-cloud
Copy link

nx-cloud bot commented Jan 19, 2026

View your CI Pipeline Execution ↗ for commit d9cbbcb

Command Status Duration Result
nx run-many -t compile,check,knip,test,pretty-d... ✅ Succeeded 9m 4s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-19 17:21:36 UTC

@nx-cloud
Copy link

nx-cloud bot commented Jan 19, 2026

View your CI Pipeline Execution ↗ for commit d9cbbcb


☁️ Nx Cloud last updated this comment at 2026-01-19 17:11:27 UTC

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 19, 2026

📝 Walkthrough

Walkthrough

Modified the navigation reachability condition in the Sidebar search component. The isNavReachable property now evaluates based on both menu state and input length, rather than input length alone. When the menu is closed or input is empty, navigation becomes reachable.

Changes

Cohort / File(s) Change Summary
Sidebar Search Navigation Logic
code/core/src/manager/components/sidebar/Search.tsx
Updated isNavReachable condition to consider menu open/closed state in addition to input field state. Condition now returns true when menu is not open OR input is empty.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@storybook-app-bot
Copy link

Package Benchmarks

Commit: d9cbbcb, ran on 19 January 2026 at 17:19:48 UTC

The following packages have significant changes to their size or dependencies:

@storybook/nextjs

Before After Difference
Dependency count 538 538 0
Self size 646 KB 646 KB 🎉 -10 B 🎉
Dependency size 59.22 MB 59.28 MB 🚨 +58 KB 🚨
Bundle Size Analyzer Link Link

@storybook/nextjs-vite

Before After Difference
Dependency count 127 127 0
Self size 1.12 MB 1.12 MB 🚨 +14 B 🚨
Dependency size 21.82 MB 21.87 MB 🚨 +49 KB 🚨
Bundle Size Analyzer Link Link

@storybook/react-native-web-vite

Before After Difference
Dependency count 159 159 0
Self size 30 KB 30 KB 🚨 +8 B 🚨
Dependency size 23.00 MB 23.17 MB 🚨 +164 KB 🚨
Bundle Size Analyzer Link Link

@storybook/react-vite

Before After Difference
Dependency count 117 117 0
Self size 35 KB 35 KB 🎉 -8 B 🎉
Dependency size 19.62 MB 19.66 MB 🚨 +49 KB 🚨
Bundle Size Analyzer Link Link

@storybook/react-webpack5

Before After Difference
Dependency count 278 278 0
Self size 24 KB 24 KB 🚨 +2 B 🚨
Dependency size 44.13 MB 44.19 MB 🚨 +58 KB 🚨
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 183 183 0
Self size 775 KB 775 KB 🚨 +223 B 🚨
Dependency size 67.38 MB 67.46 MB 🚨 +79 KB 🚨
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 176 176 0
Self size 30 KB 30 KB 🎉 -4 B 🎉
Dependency size 65.95 MB 66.03 MB 🚨 +79 KB 🚨
Bundle Size Analyzer Link Link

@storybook/react

Before After Difference
Dependency count 57 57 0
Self size 732 KB 781 KB 🚨 +49 KB 🚨
Dependency size 12.94 MB 12.94 MB 🚨 +409 B 🚨
Bundle Size Analyzer Link Link
@ghengeveld ghengeveld merged commit 61c1494 into next Jan 19, 2026
129 of 131 checks passed
@ghengeveld ghengeveld deleted the sidnioulz/fix-sidebar-after-search branch January 19, 2026 20:04
@github-actions github-actions bot mentioned this pull request Jan 19, 2026
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment