Skip to content

Conversation

@ia319
Copy link
Member

@ia319 ia319 commented Dec 1, 2025

Closes #33197, #32835

What I did

Due to dynamically computing the CWD, patterns starting with ! (e.g., !(_atoms)/**/*) were incorrectly interpreted by globby as negation patterns (exclusions) instead of extended globs (inclusions).

This change restores the custom CWD logic and prepends ./ to any pattern beginning with !. This ensures globby interprets the pattern as a relative file path using extended glob syntax (e.g., ./!(_atoms)/**/*), allowing the intended files to be matched correctly.

Since the original issue did not provide a reproduction repository, I created a sandbox based on the description to verify the fix:
https://github.com/ia319/storybook-PR-Preview-Sandbox/tree/main/negated-glob-patterns

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Bug Fixes
    • Improved glob pattern matching and directory handling to ensure reliable file discovery across different working directory configurations.

✏️ Tip: You can customize this high-level summary in your review settings.

restore cwd calculation logic and prepend "./" to negated patterns so they are treated as extended globs
@ia319 ia319 added the ci:normal label Dec 1, 2025
@nx-cloud
Copy link

nx-cloud bot commented Dec 1, 2025

View your CI Pipeline Execution ↗ for commit c7ac92c

Command Status Duration Result
nx run-many -t compile --parallel=3 ✅ Succeeded 45s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-01 13:52:34 UTC

@ia319 ia319 requested a review from ndelangen December 1, 2025 10:23
@coderabbitai

This comment was marked as spam.

@ndelangen
Copy link
Member

ndelangen commented Dec 1, 2025

I verified the repro, though the indenting is a bit off, I can see that in the second stories entries, the atoms are excluded

Screenshot 2025-12-01 at 15 17 31
@valentinpalkovic valentinpalkovic changed the title fix(core): fix cwd handling for negated globs Dec 2, 2025
@valentinpalkovic valentinpalkovic changed the title Core: fix cwd handling for negated globs Dec 2, 2025
@valentinpalkovic valentinpalkovic merged commit 453d754 into storybookjs:next Dec 2, 2025
59 of 61 checks passed
@github-actions github-actions bot mentioned this pull request Dec 2, 2025
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants