Skip to content

Conversation

@Shnatsel
Copy link
Member

Undo introducing misleading documentation, following the clarifications from miniz_oxide author in #430 (comment)

I think it is still desirable to have some support for miniz_oxide level 10, but doing it properly will require code changes and not just documentation. For example, letting the API user set 10 and automatically lowering it to 9 when using one of the zlib backends, so that Cargo feature unification wouldn't outright break people's code. That will need some API design work, so I want to get the misleading docs out of the way ASAP. Sorry 😓

Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

No worries about it - this happens, and in the end, it's me who should have done a better review as well.

@Byron Byron merged commit 60dde84 into rust-lang:main Jul 20, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants