Revert caching a default SSLContext #6767
Conversation
nateprewitt
force-pushed
the
remove_cached_sslcontext
branch
from
ce40c46 to
d520f46
Compare
|
Is this still planned to be reverted? |
|
I would also suggest to revert it ASAP. |
|
@sigmavirus24 I applied this PR as a patch to my server and it stopped the core dumps i was experiencing. When is this going to be merged and released? |
|
@dkliban It should go out with the next release. We'll update once we have a clearer timeline, we'll see what we can do next week. |
|
@nateprewitt Thank you for merging! Looking forward to the release! |
|
@nateprewitt any updates on when this will be released? |
https://build.opensuse.org/request/show/1293092 by user dgarcia + anag_factory - Add revert-caching-default-sslcontext.patch upstream patch to avoid problems with certificate caching in sslcontext. bsc#1246104, gh#psf/requests#6767
This comment has been minimized.
This comment has been minimized.
|
I had hoped that this would also fix #6647 but on my local testing it doesn't seem that it has. Should this PR have fixed that? Or was that one caused by something else? |
7 participants
This PR reverts the changes from #6667 to the previous behavior. Due to the number of edge cases and concurrency issues we've encountered with this change, we've decided the benefit doesn't currently outweigh the pain to existing infrastructure. We've iterated on a few tries to keep this functionality in place, but are still receiving reports of novel issues with this behavior.
We may be able to revisit this in a later version of Requests but we'll need a much more comprehensive test plan.