Skip to content

feat: add handling for extension range options #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 10, 2024
Merged

feat: add handling for extension range options #1990

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f265ab9
Add handling for extension range options
mkruskal-google May 8, 2024
74f612d
Fix CI failures
mkruskal-google May 9, 2024
71c59d2
Fix more test issues
mkruskal-google May 10, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix CI failures
  • Loading branch information
@mkruskal-google
mkruskal-google committed May 9, 2024
commit 74f612d3c0af8780ca9e3353c46bd155b1a8c12e
2 changes: 1 addition & 1 deletion src/parse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ function parse(source, root, options) {
dummy,
function parseRange_block(token) {
/* istanbul ignore else */
if (token === 'option') {
if (token === "option") {
parseOption(dummy, token); // skip
skip(';');
} else
Expand Down
4 changes: 2 additions & 2 deletions tests/data/uncommon.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,11 @@ message Test2 {
extend Test;
extend Test{};
extend Test{required int32 a=1;} // not validated by the parser
extend Test{Test a=1000;} // not validated by the parser
extend Test{Test inner_ext=1000;} // not validated by the parser

extensions 1000 to 1999 [declaration = {
number: 1000
full_name: 'uncommon.Test.a'
full_name: 'uncommon.Test.inner_ext'
type: 'uncommon.Test'
}]
};
Expand Down