Skip to content

Bump config file format version#6786

Merged
jack-berg merged 3 commits intoopen-telemetry:mainfrom
trask:bump-config-format-number
Oct 15, 2024
Merged

Bump config file format version#6786
jack-berg merged 3 commits intoopen-telemetry:mainfrom
trask:bump-config-format-number

Conversation

@trask
Copy link
Member

@trask trask commented Oct 11, 2024

(CI failing until #6785 is merged and this is rebased)

@trask trask force-pushed the bump-config-format-number branch from c70820c to 0339e4e Compare October 11, 2024 21:34
@trask trask force-pushed the bump-config-format-number branch from 0339e4e to 0868ed7 Compare October 11, 2024 21:41
@trask trask marked this pull request as ready for review October 11, 2024 21:53
@trask trask requested a review from a team as a code owner October 11, 2024 21:53
Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah its a bummer we missed this. Opened open-telemetry/opentelemetry-configuration#132 to prevent issues like this in the future.

@trask trask closed this Oct 14, 2024
@trask trask deleted the bump-config-format-number branch October 14, 2024 20:54
@jack-berg
Copy link
Member

Why close the PR?

@trask
Copy link
Member Author

trask commented Oct 14, 2024

oops! I was cleaning up old branches and I thought this one was merged already

@trask trask restored the bump-config-format-number branch October 14, 2024 23:16
@trask trask reopened this Oct 14, 2024
@codecov
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.11%. Comparing base (b1cd30e) to head (9023d2b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6786      +/-   ##
============================================
- Coverage     90.12%   90.11%   -0.02%     
+ Complexity     6546     6545       -1     
============================================
  Files           728      728              
  Lines         19702    19702              
  Branches       1935     1935              
============================================
- Hits          17756    17754       -2     
  Misses         1347     1347              
- Partials        599      601       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg jack-berg merged commit 83b30b5 into open-telemetry:main Oct 15, 2024
@trask trask deleted the bump-config-format-number branch October 20, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants