Adding model as suffix to generated classes.#6721
Merged
jack-berg merged 3 commits intoopen-telemetry:mainfrom Sep 18, 2024
Merged
Adding model as suffix to generated classes.#6721jack-berg merged 3 commits intoopen-telemetry:mainfrom
jack-berg merged 3 commits intoopen-telemetry:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6721 +/- ##
============================================
- Coverage 90.11% 90.08% -0.03%
+ Complexity 6392 6390 -2
============================================
Files 711 711
Lines 19333 19333
Branches 1891 1891
============================================
- Hits 17421 17417 -4
- Misses 1333 1335 +2
- Partials 579 581 +2 ☔ View full report in Codecov by Sentry. |
breedx-splk
approved these changes
Sep 13, 2024
Contributor
breedx-splk
left a comment
breedx-splk
left a comment
There was a problem hiding this comment.
LGTM thanks for picking this up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Change
We are adding model as suffix to all the generated classes. This pr resolves 6676