Load file config YAML using core schema, ensure that env var substiut…#6436
Merged
jack-berg merged 3 commits intoopen-telemetry:mainfrom May 20, 2024
Merged
Conversation
…tion retains string types
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6436 +/- ##
============================================
- Coverage 90.90% 90.86% -0.04%
Complexity 6169 6169
============================================
Files 678 678
Lines 18484 18507 +23
Branches 1813 1818 +5
============================================
+ Hits 16802 16817 +15
- Misses 1147 1154 +7
- Partials 535 536 +1 ☔ View full report in Codecov by Sentry. |
laurit
approved these changes
May 14, 2024
...tor/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/FileConfiguration.java
Outdated
Show resolved
Hide resolved
...tor/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/FileConfiguration.java
Outdated
Show resolved
Hide resolved
breedx-splk
approved these changes
May 17, 2024
Contributor
breedx-splk
left a comment
breedx-splk
left a comment
There was a problem hiding this comment.
Yeah this is great. I had a few nitpick/small comments, but good work overall. 🥂
| List<NodeTuple> nodeValue = node.getValue(); | ||
| for (NodeTuple tuple : nodeValue) { | ||
| Node keyNode = tuple.getKeyNode(); | ||
| Node valueNode = tuple.getValueNode(); |
Contributor
There was a problem hiding this comment.
Maybe move the valueNode down closer to where it's used.
...tor/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/FileConfiguration.java
Outdated
Show resolved
Hide resolved
...tor/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/FileConfiguration.java
Outdated
Show resolved
Hide resolved
...tor/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/FileConfiguration.java
Outdated
Show resolved
Hide resolved
...est/java/io/opentelemetry/sdk/extension/incubator/fileconfig/FileConfigurationParseTest.java
Show resolved
Hide resolved
…y-java into file-config-core-schema
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tion retains string types
Reflects a couple of recent spec PRs: