Skip to content

Bug: revises Exception type #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Bug: revises Exception type #1994

merged 3 commits into from
Aug 14, 2024

Conversation

chalmerlowe
Copy link
Collaborator

@chalmerlowe chalmerlowe commented Aug 14, 2024

Revises an exception type to a type that is more descriptive of the true problem.

Specifically, migrates from an http.client.FORBIDDEN exception to an TooManyRequests Error if a user experiences a rateLimitExceeded condition. This enables automated systems to more appropriately respond in situations where the rate limit is exceeded.

Fixes #1985 🦕

Copy link

conventional-commit-lint-gcf bot commented Aug 14, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Aug 14, 2024
@chalmerlowe
Copy link
Collaborator Author

The failure of the Kokoro docs-presubmit is a separate issue and is being handled in this PR:
#1995

@chalmerlowe chalmerlowe self-assigned this Aug 14, 2024
@chalmerlowe chalmerlowe requested a review from suzmue August 14, 2024 16:23
@chalmerlowe chalmerlowe marked this pull request as ready for review August 14, 2024 16:23
@chalmerlowe chalmerlowe requested review from a team as code owners August 14, 2024 16:23
@chalmerlowe chalmerlowe merged commit e7e0fcf into main Aug 14, 2024
19 of 20 checks passed
@chalmerlowe chalmerlowe deleted the fix-rate-limit-exceeded branch August 14, 2024 16:30
@cozos
Copy link

cozos commented Aug 18, 2024

Thank you so much @chalmerlowe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.
3 participants