Skip to content

fix: add warning when encountering unknown field types #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 13, 2024
Merged

fix: add warning when encountering unknown field types #1989

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a3efe4a
fix: add warning when encountering unknown field types
suzmue Aug 2, 2024
fa8329f
fix: add warning for unknown subfield types as well
suzmue Aug 3, 2024
f382169
fix: remove unused warnings
suzmue Aug 3, 2024
f4e006f
fix: remove leftover debugging code
suzmue Aug 3, 2024
83ee4aa
move test case closer to related test
suzmue Aug 3, 2024
d1d1eb4
add comments
suzmue Aug 3, 2024
a379e7b
fix formatting
suzmue Aug 5, 2024
93dda16
fix test_table and use warnings.warn instead of pytest.warn
suzmue Aug 5, 2024
2be2830
add explicit warning about behavior subject to change in the future
suzmue Aug 5, 2024
094e7dc
add default converter for _SCALAR_VALUE_TO_JSON_PARAM
suzmue Aug 7, 2024
f29bb05
factor out shared warning
suzmue Aug 7, 2024
c0b6272
fix test case and make coverage happy
suzmue Aug 7, 2024
be54ee5
add unit test to StructQueryParameter class
suzmue Aug 7, 2024
a253165
Merge branch 'main' into warnConversion
Linchin Aug 12, 2024
cce5596
Merge branch 'main' into warnConversion
Linchin Aug 13, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move test case closer to related test
  • Loading branch information
@suzmue
suzmue committed Aug 3, 2024
commit 83ee4aa7d8e851db70295eb33131cfc867a88b18
16 changes: 8 additions & 8 deletions tests/unit/test__helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,14 +648,6 @@ def test_w_unknown_type(self):
self.assertEqual(self._call_fut(row, schema=[col]), ('1',))
self.assertEqual(len(record), 1)

def test_w_unknown_type_repeated(self):
# SELECT 1 AS col
col = _Field("REPEATED", "col", "UNKNOWN")
row = {"f": [{"v": [{"v": "1"}, {"v": "2"}, {"v": "3"}]}]}
with pytest.warns(FutureWarning, match="Unknown field type 'UNKNOWN'.") as record:
self.assertEqual(self._call_fut(row, schema=[col]), (['1', '2', '3'],))
self.assertEqual(len(record), 1)

def test_w_single_scalar_geography_column(self):
# SELECT 1 AS col
col = _Field("REQUIRED", "geo", "GEOGRAPHY")
Expand All @@ -676,6 +668,14 @@ def test_w_single_array_column(self):
row = {"f": [{"v": [{"v": "1"}, {"v": "2"}, {"v": "3"}]}]}
self.assertEqual(self._call_fut(row, schema=[col]), ([1, 2, 3],))

def test_w_unknown_type_repeated(self):
# SELECT 1 AS col
col = _Field("REPEATED", "col", "UNKNOWN")
row = {"f": [{"v": [{"v": "1"}, {"v": "2"}, {"v": "3"}]}]}
with pytest.warns(FutureWarning, match="Unknown field type 'UNKNOWN'.") as record:
self.assertEqual(self._call_fut(row, schema=[col]), (['1', '2', '3'],))
self.assertEqual(len(record), 1)

def test_w_struct_w_nested_array_column(self):
# SELECT ([1, 2], 3, [4, 5]) as col
first = _Field("REPEATED", "first", "INTEGER")
Expand Down