Skip to content

Fix bug in getElementType logic #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 20, 2024
Merged

Fix bug in getElementType logic #525

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ca7a3c3
Update tests and command
khiga8 May 16, 2024
9deac20
Fix bug
khiga8 May 16, 2024
f7d1592
Add .js extension so tests pass
khiga8 May 16, 2024
9600041
fix bugs
khiga8 May 16, 2024
e6f3c9e
update code comment
khiga8 May 16, 2024
d134206
drop node 14
khiga8 May 16, 2024
dd592c6
drop ndoe 16
khiga8 May 16, 2024
9d2dc5d
add node 20 support
khiga8 May 16, 2024
3979a24
Update tests/utils/get-element-type.mjs
khiga8 May 16, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
drop ndoe 16
  • Loading branch information
@khiga8
khiga8 committed May 16, 2024
commit dd592c6775de194a4f50ff01837013151c6f76ae
2 changes: 1 addition & 1 deletion .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:

strategy:
matrix:
node-version: [16, 18]
node-version: [18]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add 20? I've been seeing more Actions migrate to it, and it's now a year old; if nothing breaks might be nice to start testing against it.

(disclaimer: I'm not the expert on node versions.)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh okay! let's see what it tells us!
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOO! Added, and passed!

steps:
- uses: actions/checkout@v4
Expand Down