Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add comment per code review
  • Loading branch information
pragatimodi committed Mar 18, 2024
commit 5a41523af9efa361d35a778c4252ab515be3f3b1
2 changes: 2 additions & 0 deletions src/auth/token-verifier.ts
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,8 @@ export class FirebaseTokenVerifier {
payload.iss + '".' + projectIdMatchMessage + verifyJwtTokenDocsMessage;
} else if (!(payload.event_type !== undefined &&
(payload.event_type === 'beforeSendSms' || payload.event_type === 'beforeSendEmail'))) {
// excluding `beforeSendSms` and `beforeSendEmail` from processing `sub` as there is no user record available.
// `sub` is the same as `uid` which is part of the user record.
if (typeof payload.sub !== 'string') {
errorMessage = `${this.tokenInfo.jwtName} has no "sub" (subject) claim.` + verifyJwtTokenDocsMessage;
} else if (payload.sub === '') {
Expand Down