fix current context as builder name for docker driver #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
docker-context
branch
from
50308af to
efe966c
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
docker-context
branch
from
efe966c to
30389db
Compare
jedevc
approved these changes
Mar 3, 2023
fuxingloh
referenced
this pull request
in DeFiCh/jellyfishsdk
Mar 13, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [docker/setup-buildx-action](https://togithub.com/docker/setup-buildx-action) | action | minor | `v2.4.1` -> `v2.5.0` | --- ### Release Notes <details> <summary>docker/setup-buildx-action</summary> ### [`v2.5.0`](https://togithub.com/docker/setup-buildx-action/releases/tag/v2.5.0) [Compare Source](https://togithub.com/docker/setup-buildx-action/compare/v2.4.1...v2.5.0) - `cleanup` input to remove builder and temp files by [@​crazy-max](https://togithub.com/crazy-max) in [https://github.com/docker/setup-buildx-action/pull/213](https://togithub.com/docker/setup-buildx-action/pull/213) - do not remove builder using the `docker` driver by [@​crazy-max](https://togithub.com/crazy-max) in [https://github.com/docker/setup-buildx-action/pull/218](https://togithub.com/docker/setup-buildx-action/pull/218) - fix current context as builder name for `docker` driver by [@​crazy-max](https://togithub.com/crazy-max) in [https://github.com/docker/setup-buildx-action/pull/209](https://togithub.com/docker/setup-buildx-action/pull/209) **Full Changelog**: docker/setup-buildx-action@v2.4.1...v2.5.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/JellyfishSDK/jellyfish). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNjAuMCIsInVwZGF0ZWRJblZlciI6IjM0LjE2MC4wIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
scottames
referenced
this pull request
in scottames/dots
Apr 17, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [docker/setup-buildx-action](https://togithub.com/docker/setup-buildx-action) | action | minor | `v2.2.1` -> `v2.5.0` | --- ### Release Notes <details> <summary>docker/setup-buildx-action</summary> ### [`v2.5.0`](https://togithub.com/docker/setup-buildx-action/releases/tag/v2.5.0) [Compare Source](https://togithub.com/docker/setup-buildx-action/compare/v2.4.1...v2.5.0) - `cleanup` input to remove builder and temp files by [@​crazy-max](https://togithub.com/crazy-max) in [https://github.com/docker/setup-buildx-action/pull/213](https://togithub.com/docker/setup-buildx-action/pull/213) - do not remove builder using the `docker` driver by [@​crazy-max](https://togithub.com/crazy-max) in [https://github.com/docker/setup-buildx-action/pull/218](https://togithub.com/docker/setup-buildx-action/pull/218) - fix current context as builder name for `docker` driver by [@​crazy-max](https://togithub.com/crazy-max) in [https://github.com/docker/setup-buildx-action/pull/209](https://togithub.com/docker/setup-buildx-action/pull/209) **Full Changelog**: docker/setup-buildx-action@v2.4.1...v2.5.0 ### [`v2.4.1`](https://togithub.com/docker/setup-buildx-action/releases/tag/v2.4.1) [Compare Source](https://togithub.com/docker/setup-buildx-action/compare/v2.4.0...v2.4.1) - Get releases from actions toolkit by [@​crazy-max](https://togithub.com/crazy-max) ([#​200](https://togithub.com/docker/setup-buildx-action/issues/200)) - Bump csv-parse from 5.3.3 to 5.3.4 ([#​199](https://togithub.com/docker/setup-buildx-action/issues/199)) **Full Changelog**: docker/setup-buildx-action@v2.4.0...v2.4.1 ### [`v2.4.0`](https://togithub.com/docker/setup-buildx-action/releases/tag/v2.4.0) [Compare Source](https://togithub.com/docker/setup-buildx-action/compare/v2.3.0...v2.4.0) - Don't depend on the GitHub API to check release by [@​crazy-max](https://togithub.com/crazy-max) ([#​196](https://togithub.com/docker/setup-buildx-action/issues/196)) **Full Changelog**: docker/setup-buildx-action@v2.3.0...v2.4.0 ### [`v2.3.0`](https://togithub.com/docker/setup-buildx-action/releases/tag/v2.3.0) [Compare Source](https://togithub.com/docker/setup-buildx-action/compare/v2.2.1...v2.3.0) - Use Octokit to check Buildx release on GitHub by [@​crazy-max](https://togithub.com/crazy-max) ([#​191](https://togithub.com/docker/setup-buildx-action/issues/191) [#​192](https://togithub.com/docker/setup-buildx-action/issues/192)) - Add version pinning information to the README by [@​jedevc](https://togithub.com/jedevc) ([#​189](https://togithub.com/docker/setup-buildx-action/issues/189)) - Bump minimatch from 3.0.4 to 3.1.2 ([#​182](https://togithub.com/docker/setup-buildx-action/issues/182)) - Bump csv-parse from 5.3.1 to 5.3.3 ([#​181](https://togithub.com/docker/setup-buildx-action/issues/181)) - Bump json5 from 2.2.0 to 2.2.3 ([#​184](https://togithub.com/docker/setup-buildx-action/issues/184)) **Full Changelog**: docker/setup-buildx-action@v2.2.1...v2.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/scottames/dots). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40MC4wIiwidXBkYXRlZEluVmVyIjoiMzUuNDAuMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs #204Currently we enforce
defaultas builder name when thedockerdriver is used but in some cases it can be another name if a previous step defines a custom context. This change will use the default context returned by https://github.com/docker/actions-toolkit/blob/fda3be96990901cef44bbd639c64b84e2fe91c47/src/docker/docker.ts#L41.