Add support for selector order preservation to postcss-minify-selectors #1688
+31
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
alexander-akait
requested changes
Mar 13, 2025
| } | ||
| }); | ||
| selectors.nodes.sort(); | ||
| if (opts.preserveOrder !== true) { |
Member
There was a problem hiding this comment.
Please avoid using no/preserve/etc, mostly such names are very misleading, let's use sort: boolean, by default true and when it is false we will do nothing
alexander-akait
previously approved these changes
Mar 14, 2025
Member
|
Looks like some tests are failed, can you look? |
Contributor
Author
|
Tests/presets were broken because by default an empty option object is passed to plugins, and default preset was not passing |
ludofischer
approved these changes
Mar 18, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(minify-selectors): Add the ability to disable sorting when minifying selectors