-
-
Notifications
You must be signed in to change notification settings - Fork 839
fix(plugins): normalize relative plugin paths during config loading #8524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugins): normalize relative plugin paths during config loading #8524
Conversation
🦋 Changeset detectedLatest commit: 7d98151 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughNormalises plugin paths after configuration Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
e4d063a to
e127306
Compare
This comment has been minimized.
This comment has been minimized.
|
@dyc3 are you able to review this PR? |
e127306 to
7d98151
Compare
arendjr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn’t look into the code too deeply, but if tests are green and you can confirm the fix works, @deww400 , I think it may be good to go.
dyc3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Fixes #8488.
In monorepos where nested configurations use
extends: "//", relative plugin paths declared in the root configuration could be resolved relative to the child configuration directory, causing plugin loading to fail with "Cannot read file." This is related to theextends: "//"behavior discussed in #8360.This PR normalizes plugin paths relative to the directory of the configuration file that declares them so that merged configurations keep consistent plugin path semantics.
AI disclosure: I used AI assistance (Cursor / GPT) to explore the codebase and draft the fix and tests.
Test Plan
extends: "//".Commands run:
cargo test -p biome_plugin_loadercargo test -p biome_cli --test main -- cases::monorepocargo test -p biome_servicecargo fmt --checkcargo clippy -p biome_service -p biome_cli -p biome_plugin_loader -- -D warningsDocs
No documentation changes are needed (bugfix only).