fix(lsp): require config and code actions

[ematipico]

Summary

This PR closes two bugs.

Closes #6287

To fix this bug, I had to apply the following changes:

• when loading the configuration, now we check if the configuration folder is empty. If it is empty, and the editor require the configuration, when we return early with ConfigurationStatus::Missed.
• the language server request textDocument/codeAction must be registered dynamically. We already do so with formatting requests too.

The second bug was related to how we compute the code actions to provide to the editors. I must admit that there was a lot of confusion on my part (and possibly others') in understanding the feature and correctly applying it to the code.

When the client requests textDocument/codeAction, we simply need to provide the code actions available to a diagnostic. Those code actions are the ones that belong to the choices that the editor provides when clicking Cmd + .. This means that we need to provide ALL code actions: the safe fix, the inline suppression and the top-level suppression. The user will choose what they want.

When configuring codeActionsOnSave / code_actions_on_format, the user chooses which ones should be applied among the ones listed.

Given the previous statements, I adjusted the code, and I also added and fixed some checks: we now check both assist and linter.

Important

There's still a small bug where we provide suppressions regardless of whether the action is a lint rule or an assist action. This requires some refactoring that I prefer to tackle in a different PR.

I also updated the label of the fixAll action. This is how it looks like:

Test Plan

I did manual testing in Zed and VSCode and made sure they behave the same.
Updated the tests, and removed one test that doesn't make sense anymore.

[changeset-bot]

🦋 Changeset detected

Latest commit: 067c84d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[arendjr]

Good stuff!