Skip to content

Disallow using in bare case statement #17323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 29, 2025

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented May 20, 2025

Q                       A
Fixed Issues? Implements rbuckton/ecma262#14
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

rbuckton/ecma262#14 has reached consensus in the Apr 2025 meeting. In this PR we implement the proposed normative change.

We also removed the switch case handling in the using transform now that such cases have been rejected by the parser.

@JLHwung JLHwung added PR: Spec Compliance 👓 A type of pull request used for our changelog categories Spec: Explicit Resource Management labels May 20, 2025
@babel-bot
Copy link
Collaborator

babel-bot commented May 20, 2025

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/59368

@nicolo-ribaudo
Copy link
Member

I opened tc39/test262#4498 for the test262 failures.

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@nicolo-ribaudo nicolo-ribaudo merged commit f58e67b into babel:main May 29, 2025
56 of 57 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the disallow-using-in-bare-case branch May 29, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Spec Compliance 👓 A type of pull request used for our changelog categories Spec: Explicit Resource Management
4 participants