feat(router): Support wildcard params with segments trailing #64737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this adds support for both leading and trailing segments before/after wildcard route. Exposig the segments in a new _splat param would require a breaking change to the return value of the matchers. fixes angular#60821
atscott
added
requires: TGP
pullapprove
bot
removed
the
requires: TGP
Contributor
Author
atscott
added
the
target: feature
AndrewKushnir
approved these changes
Oct 29, 2025
atscott
added
action: merge
Contributor
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
Platonn
reviewed
Nov 28, 2025
Comment on lines
+617
to
+620
| { | ||
| path: '**/b', | ||
| component: ComponentB, | ||
| }, |
Contributor
There was a problem hiding this comment.
Hi @atscott . Thank you for supporting more sophisticated wildcard route paths, so that we don't need to build custom UrlMatchers in such cases (that are tricky to write and test).
FYI In our Spartacus library in the past we've built custom "suffix url matchers", e.g. to match a pattern like **/p/:productCode.
So let me ask a question for our usecase: Is this PR supporting also dynamic params (:param) as the URL segments? I'm asking, as I'm having problem to find unit tests for this case.
Contributor
Author
There was a problem hiding this comment.
No, this only supports static suffixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds support for both leading and trailing segments before/after wildcard route. Exposig the segments in a new _splat param would require a breaking change to the return value of the matchers.
fixes #60821