[PR #3955/8960063e backport][3.10] Replace all tmpdir fixtures with tmp_path (#3551) #8075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
) tmp_path is the replacement fixture in pytest for tmpdir; tmp_path uses the builtin pathlib.Path class. As it says on the tin, this commit replaces every instance of tmpdir in the test suite with tmp_path. Aside from s/tmpdir/tmp_path/ this also required changing instances of `tmpdir.join(foo)` to `tmp_path / foo`. This is intended to comprehensively address aio-libs#3551 and should have no side effects. (cherry picked from commit 8960063)
webknjaz
force-pushed
the
patchback/backports/3.10/8960063ef4137d6c547a687a45ed55b943e9b8d1/pr-3955
branch
from
0f3d4d3 to
01a386c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.10 #8075 +/- ##
==========================================
- Coverage 97.39% 97.30% -0.09%
==========================================
Files 108 108
Lines 32812 32887 +75
Branches 3904 3927 +23
==========================================
+ Hits 31957 32002 +45
- Misses 650 675 +25
- Partials 205 210 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
webknjaz
deleted the
patchback/backports/3.10/8960063ef4137d6c547a687a45ed55b943e9b8d1/pr-3955
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #3955 as merged into master (8960063).
tmp_path is the replacement fixture in pytest for tmpdir; tmp_path
uses the builtin pathlib.Path class. As it says on the tin, this
commit replaces every instance of tmpdir in the test suite with
tmp_path. Aside from s/tmpdir/tmp_path/ this also required changing
instances of
tmpdir.join(foo)totmp_path / foo.This is intended to comprehensively address and close #3551, and
should have no side effects. This does not affect end users.