Repository navigation
ci: build with Amazon Corretto instead of adopt - #9
Merged
Merged
Conversation
setup-java v6 removed the adopt distribution, so the next setup-java
bump would fail ("No supported distribution was found for input adopt").
Switch every setup-java step to distribution: corretto, the JDK we run
in prod on AWS. The setup-java v1 steps had no distribution input (v1
installs Zulu); they get distribution: corretto too. Steps on setup-java
v1 move to v3, the lowest version with Corretto; later version bumps are
left to Dependabot.
Part of OriginAS/origin-infrastructure#109.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gskjold
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
actions/setup-javav6 removed theadoptdistribution (v6.0.0 release notes: "Remove legacy Adopt distributions in v6", actions/setup-java#1185). The next setup-java bump would fail withNo supported distribution was found for input adopt, as it already does in OriginAS/must-booking#9.We build with Amazon Corretto (
distribution: corretto) because prod runs on AWS.Steps on setup-java v1/v2 move to v3, the lowest version that has Corretto. Steps already on v3+ keep their version.
Part of OriginAS/origin-infrastructure#109.
Changed steps
.github/workflows/deploy-craft.ymldeployadopt→corretto${{ inputs.jdk }}.github/workflows/deploy-jetty-2.ymldeployadopt→corretto${{ inputs.jdk }}.github/workflows/deploy-jetty-hrfi.ymldeployadopt→corretto${{ inputs.jdk }}.github/workflows/deploy-spring-boot-hrfi.ymldeployadopt→corretto${{ inputs.jdk }}.github/workflows/deploy-spring-boot.ymldeployadopt→corretto${{ inputs.jdk }}.github/workflows/maven-build-hrfi.ymlbuildcorretto${{ inputs.jdk }}.github/workflows/maven-build.ymlbuildcorretto${{ inputs.jdk }}.github/workflows/maven-release-hrfi.ymlbuildcorretto${{ inputs.jdk }}.github/workflows/maven-release.ymlbuildadopt→corretto${{ inputs.jdk }}No Java version changes in this PR. Nothing else changes either: no other steps, action versions, step names or formatting.
Notes
@main, so the change reaches all callers on merge. The first caller build/release/deploy after merge is the real test.~/.m2/settings.xmlwith server idgithubandGITHUB_ACTOR/GITHUB_TOKENby default. Nothing in these jobs writes its ownsettings.xmlbefore the bumped step (any "Configure Maven" step runs after it), so the result is the same.java-version: ${{ inputs.jdk }}). Corretto only takes major versions, so I checked thejdk:values every caller passes (gh search code --owner OriginAS "origin-actions/.github/workflows/", 57 caller files, all@main):deploy-jetty-hrfi.yml: 11, not passed (default)deploy-spring-boot-hrfi.yml: 11maven-build-hrfi.yml: not passed (default)maven-build.yml: 17, 25, not passed (default)maven-release-hrfi.yml: not passed (default)maven-release.yml: 17, 211.8,11.0.5); the input defaults are 11 or 17. All callers use@main, so this takes effect for all of them on merge.deploy-craft.ymluses${{ inputs.jdk }}and${{ inputs.goals }}but declares neither input, and no caller was found. That is pre-existing and unchanged here.Open PRs touching the same workflow files
None.
🤖 Generated with Claude Code