Tags: zebp/tools
Tags
internal/lsp/source: canonicalize objects in reference/rename requests With generics, instantiated object may have differing pointer identities. Fix references/rename requests for instantiated methods/fields by using a canonical object identity of (pos, pkg, name). Fixes golang/go#51672 Change-Id: I0021ca562b8a74dadb616cf6864cb0bdd0165cc3 Reviewed-on: https://go-review.googlesource.com/c/tools/+/392480 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
gopls: update go.mod file to pick up CL 392914 For golang/go#51219 Change-Id: Ib60fc1f22ce9ff094bc87ec36ad9e2c07c422c6e Reviewed-on: https://go-review.googlesource.com/c/tools/+/392915 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
gopls: update go.mod file to pick up CL 392914 For golang/go#51219 Change-Id: Ib60fc1f22ce9ff094bc87ec36ad9e2c07c422c6e Reviewed-on: https://go-review.googlesource.com/c/tools/+/392915 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
gopls: update go.mod file for v0.8.1 For golang/go#51219 Change-Id: I62982e0ea084f78e81ec5ea6d6a0b6a039941968 Reviewed-on: https://go-review.googlesource.com/c/tools/+/392634 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Suzy Mueller <suzmue@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org>
gopls: update go.mod to pick up CL 389494 Update to include recently cherry-picked x/tools changes. For golang/go#51074 Change-Id: Iae465b09b9c1f751c118d43eb37910696a72ebdd Reviewed-on: https://go-review.googlesource.com/c/tools/+/389714 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
gopls: update go.mod to pick up CL 389494 Update to include recently cherry-picked x/tools changes. For golang/go#51074 Change-Id: Iae465b09b9c1f751c118d43eb37910696a72ebdd Reviewed-on: https://go-review.googlesource.com/c/tools/+/389714 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
gopls: update go.mod file for v0.8.0 For golang/go#51074 Change-Id: I6ebe3470d4a3113566eaa26f32e611d3bb8ffcd1 Reviewed-on: https://go-review.googlesource.com/c/tools/+/388694 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> TryBot-Result: Gopher Robot <gobot@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com>
gopls: update go.mod file for v0.8.0-pre.2 to pick up CL 386537 For golang/go#51074 Change-Id: I5471419cfe554ff6be3181e2594dbf5e6e7f421d Reviewed-on: https://go-review.googlesource.com/c/tools/+/386734 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
gopls: update go.mod file for v0.8.0-pre.1 For golang/go#51074 Change-Id: Ia39e065480248a85a46d2b3fbbc3acb4f1ae927e Reviewed-on: https://go-review.googlesource.com/c/tools/+/384116 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> Reviewed-by: Suzy Mueller <suzmue@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
internal/lsp/regtest: eliminate arbitrary timeouts We care that gopls operations complete within a reasonable time. However, what is “reasonable” depends strongly on the specifics of the user and the hardware they are running on: a timeout that would be perfectly reasonable on a high-powered user workstation with little other load may be far too short on an overloaded and/or underpowered CI builder. This change adjusts the regtest runner to use the test deadline instead of an arbitrary, flag-defined timeout; we expect the user or system running the test to scale the test timeout appropriately to the specific platform and system load. When the testing package gains support for per-test timeouts (golang/go#48157), this approach will automatically apply those timeouts too. If we decide that we also want to test specific performance and/or latency targets, we can set up specific configurations for that (as either aggressive per-test timeouts or benchmarks) in a followup change. For golang/go#50582 Change-Id: I1ab11b2049effb097aa620046fe11609269f91c4 Reviewed-on: https://go-review.googlesource.com/c/tools/+/380497 Trust: Bryan Mills <bcmills@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>
PreviousNext