Skip to content

increase codecoverage to 80% required by silver cii bestpractices #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
szuecs merged 5 commits into from
Apr 10, 2019
Merged

increase codecoverage to 80% required by silver cii bestpractices #1025

szuecs merged 5 commits into from
Apr 10, 2019

Conversation

@szuecs
Copy link
Member

@szuecs szuecs commented Apr 9, 2019 •
edited
Loading

see https://bestpractices.coreinfrastructure.org/ silver

  • on parsing cli flags
  • add some trivia

fix golang/go#31293

Signed-off-by: Sandor Szücs sandor.szuecs@zalando.de
@szuecs szuecs added the wip work in progress label Apr 9, 2019
@szuecs
increase codecoverage on parsing cli flags
cc43acb 
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
szuecs added 2 commits April 9, 2019 18:10
@szuecs
fix travis builds
584fa51 
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
@szuecs
add more trivia tests for oidc filter
5502b32 
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
@szuecs szuecs removed the wip work in progress label Apr 9, 2019
@szuecs
Copy link
Member Author

szuecs commented Apr 9, 2019

👍
@szuecs
Copy link
Member Author

szuecs commented Apr 9, 2019

not sure how much is it now...
aryszka
aryszka reviewed Apr 10, 2019
View reviewed changes
@szuecs
remove commented test
9bac892 
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
aryszka
aryszka reviewed Apr 10, 2019
View reviewed changes
@szuecs
add get secret test
c159daf 
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
@aryszka
Copy link
Contributor

aryszka commented Apr 10, 2019

👍
1 similar comment
@szuecs
Copy link
Member Author

szuecs commented Apr 10, 2019

👍
@szuecs szuecs merged commit e354aee into master Apr 10, 2019
@szuecs szuecs deleted the test/coverage branch April 10, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@szuecs @aryszka