-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat(python-development): add fastapi skill with progressive disclosure #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kiriz
wants to merge
11
commits into
wshobson:main
Choose a base branch
from
kiriz:enhance-python-fastapi-agents
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Design for a skill that generates, corrects, and refines professional Excalidraw diagrams for architecture documentation. Key features: - Three modes: Generate, Correct, Refine - Component library from library-master.excalidrawlib (22 components) - Pattern templates for 5 diagram types - Configurable palettes (architecture, workflow, aws, k8s, minimal) - Two visual styles (hand-drawn, clean) - Technical writing rules for concise labels - 16:9 frames for presentation-ready output
New diagram-generation plugin with excalidraw-diagram skill that: - Generates professional Excalidraw diagrams (system arch, workflow, sequence, ERD, deployment) - Corrects existing diagrams (layout, colors, spacing) - Refines labels using technical writing rules - Wraps all diagrams in 16:9 frames for presentations Includes: - 5 color palettes (architecture, workflow, aws, k8s, minimal) - 5 pattern templates for each diagram type - 19 pre-built components from library-master.excalidrawlib - Primitive shapes, connectors, and label templates - Technical writing rules for concise, accurate labels Based on Open Colors (Excalidraw's native palette) and uber.excalidraw style patterns (hachure fill, roughness 1, opacity 60).
Add diagram-generation plugin entry to marketplace.json to enable installation via /plugin install command for all users.
- Add MANDATORY instruction in generation workflow to use Clients component - Add Actor/User Representation section with mapping table - Add Component Selection Priority (library > patterns > primitives) - Add output validation rules to catch incorrect user representation - Prevent use of plain ellipses/ovals for users, admins, customers, actors
… elements Add section documenting best practices for applying consistent colors to elements of the same architectural category. This prevents visual clutter and improves diagram readability when multiple similar elements (e.g., multiple cloud providers) appear together.
- Add Arrow Connections (MANDATORY) section with 3-part binding requirement - Document binding parameters: elementId, focus, gap - Add validation checks wshobson#9 and wshobson#10 for arrow integrity - Ensure arrows stay connected when diagram elements are moved
…rary - Reduce SKILL.md from 869 to 268 lines (under 500-line limit) - Add maintainer note about line limit per Anthropic best practices - Fix path discrepancies (assets/config.json, assets/palettes.json) - Add boundary styling rule (external=transparent+dashed) - Remove redundant components/library.json (replaced by categorized library) - Add categorized library/ with 92 components across 20 categories - Create reference/element-templates.md for detailed JSON templates - Create reference/icon-generation.md for icon creation guide - Follow progressive disclosure pattern per Anthropic guidelines
…cture
- Consolidate 90 individual .excalidraw files into 20 category files
- Implement structured naming: {category}-{component}-{element} for IDs
- Add groupId convention: {category}-{component} for component filtering
- Update index.json to v4 with file/groupId references
- Update LIBRARY-LOADER.md with new lookup algorithms
- Add consolidate.py and transform-to-excalidraw.py utility scripts
- Remove empty category subfolders
Benefits:
- Reduces file I/O from 90 reads to max 20 per diagram
- Enables VS Code/Excalidraw preview with .excalidraw extension
- Structured IDs allow easy component identification and rearrangement
- Flat structure simplifies maintenance
- Update library references from folder paths to flat category files - Document groupId-based component filtering approach - Update actor representation to use actors.excalidraw with groupId - Remove one-time utility scripts (consolidate.py, transform-to-excalidraw.py) - Remove backup file (index.json.backup)
- Add diagram-pro.md agent for Excalidraw diagram generation - Add diagram-generate.md command for creating new diagrams - Add diagram-fix.md command for correcting existing diagrams - Remove redundant plugin.json (marketplace.json is source of truth) - Update marketplace.json with agents and commands refs
- Create fastapi skill following temporal-python-testing pattern - SKILL.md (181 lines): essentials inline + resource navigation - resources/service-layer.md: service pattern, exceptions, settings - resources/database-patterns.md: SQLAlchemy 2.0, StaticPool testing - resources/deployment.md: Gunicorn, structlog, project structure - resources/async-patterns.md: library alternatives, circular imports - Link fastapi-pro agent to new skill - Register in marketplace.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fastapiskill following Anthropic's progressive disclosure best practicestemporal-python-testingpattern (small SKILL.md + resources/)fastapi-proagent to reference the new skillStructure
Key Patterns Included
deffor blocking,async deffor truly async@app.on_eventTest Plan
fastapi-proagent references skill correctly