Editorial: refactor parse a url #9709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
reviewed
Sep 9, 2023
Member
domenic
left a comment
domenic
left a comment
There was a problem hiding this comment.
Wow, it's amazing we've been using this awkward tuple-returning thing for so long, when only a handful of algorithms used both the string and URL record versions. Very nice!
I wonder if this will break other specs. Probably some monkeypatch ones...
domenic
approved these changes
Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on a13cfbe and 80f036c. This removes the need for resulting URL string and resulting URL record and makes parse a URL return a URL record directly.
I worked on this during XSLeaks, but I think it's good. It was a pretty mechanical process though there were some surprising cases and there's some lack of consistency in how we word things. Curious to hear what you think @domenic!
/dnd.html ( diff )
/form-control-infrastructure.html ( diff )
/iframe-embed-object.html ( diff )
/input.html ( diff )
/links.html ( diff )
/media.html ( diff )
/microdata.html ( diff )
/nav-history-apis.html ( diff )
/scripting.html ( diff )
/semantics.html ( diff )
/system-state.html ( diff )
/urls-and-fetching.html ( diff )
/webappapis.html ( diff )
/workers.html ( diff )
/worklets.html ( diff )