Raise the bar for SharedArrayBuffer via postMessage() by annevk · Pull Request #4734 · whatwg/html

annevk · 2019-06-25T15:14:57Z

This depends on the work to add Cross-Origin-Opener-Policy and Cross-Origin-Embedder-Policy. It specifies how postMessage() is affected when both those headers are set for the agent clusters they impact.

Closes #4732.

At least two implementers are interested (and none opposed):
- Firefox
- Google
Tests are written and can be reviewed and commented upon at:
Implementation bugs are filed:
- Chrome: …
- Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1477743
- Safari: …

(See WHATWG Working Mode: Changes for more details.)

/browsers.html ( diff )
/origin.html ( diff )
/structured-data.html ( diff )
/webappapis.html ( diff )
/workers.html ( diff )

For whatwg/html#4734.

The original test could not work. This should be able to work and also adds COOP/COEP headers for future proofing. No browser passes still. For whatwg/html#4734.

For whatwg/html#4734.

annevk · 2019-07-19T14:48:38Z

I've updated OP with a number of tests of which some are landed. I made the decision to land test changes as this is a large undertaking that has multi-implementer buy-in and landing it all at once would it a lot more likely we'd miss important things. The changes should minimally disrupt existing coverage. I'll try to continue to keep OP up-to-date.

…ffer success case revamp, a=testonly Automatic update from web-platform-tests HTML: BroadcastChannel and SharedArrayBuffer success case revamp The original test could not work. This should be able to work and also adds COOP/COEP headers for future proofing. No browser passes still. For whatwg/html#4734. -- wpt-commits: dedb45f5f20e0ac884ac59634cceb8659cdcff7d wpt-pr: 17760

For whatwg/html#4734.

…djustments, a=testonly Automatic update from web-platform-tests HTML: SharedArrayBuffer infrastructure adjustments For whatwg/html#4734. -- wpt-commits: a140f239fa9dc4fc3db593b664064b65340e7d4b wpt-pr: 17761 --HG-- rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/resources/broadcastchannel-iframe.html.headers => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/resources/echo-iframe.html.headers rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/resources/broadcastchannel-iframe.html.headers => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/resources/echo-worker.js.headers rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/broadcastchannel-success-and-failure.html => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/broadcastchannel-success-and-failure.https.html rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/identity-not-preserved.html => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/identity-not-preserved.https.html rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/no-transferring.html => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/no-transferring.https.html rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/resources/broadcastchannel-iframe.html.headers => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/resources/broadcastchannel-sharedworker.js.headers rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/resources/broadcastchannel-iframe.html.headers => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/resources/broadcastchannel-worker.js.headers rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/resources/broadcastchannel-iframe.html.headers => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/resources/incrementer-worker-with-channel.js.headers rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/resources/broadcastchannel-iframe.html.headers => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/resources/incrementer-worker.js.headers rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/resources/broadcastchannel-iframe.html.headers => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/resources/nested-worker-success.js.headers rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/resources/broadcastchannel-iframe.html.headers => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/resources/serviceworker-failure.js.headers rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/resources/broadcastchannel-iframe.html.headers => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/resources/sharedworker-failure.js.headers rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-history.html => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-history.https.html rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-domain-success.sub.html => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-domain-success.https.sub.html rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-iframe-messagechannel-success.html => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-iframe-messagechannel-success.https.html rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-messagechannel-success.html => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-messagechannel-success.https.html rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-sharedworker-failure.html => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-sharedworker-failure.https.html rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-similar-but-cross-origin-success.sub.html => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-similar-but-cross-origin-success.https.sub.html rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-simple-success.html => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-simple-success.https.html

…er throws without COOP+COEP, a=testonly Automatic update from web-platform-tests HTML: ensure serializing SharedArrayBuffer throws without COOP+COEP For whatwg/html#4734. -- wpt-commits: aecedb53e28abad5432227e293dd016cfc46d4b7 wpt-pr: 17802

…djustments, a=testonly Automatic update from web-platform-tests HTML: SharedArrayBuffer infrastructure adjustments For whatwg/html#4734. -- wpt-commits: a140f239fa9dc4fc3db593b664064b65340e7d4b wpt-pr: 17761

…er throws without COOP+COEP, a=testonly Automatic update from web-platform-tests HTML: ensure serializing SharedArrayBuffer throws without COOP+COEP For whatwg/html#4734. -- wpt-commits: aecedb53e28abad5432227e293dd016cfc46d4b7 wpt-pr: 17802

annevk · 2020-04-08T10:40:50Z


+  <p>An <span>agent cluster</span> has an associated <dfn>cross-origin isolated</dfn> (a boolean),
+  which is initially false.</p>
+  <!-- TODO: maybe this should move into the eventual COEP PR as it impacts shared workers? -->


@yutakahirano thoughts on this?

I'm fine with having this definition in this PR.

What kind of changes would be needed to set it accurately for shared/service workers though?

#5454 adds steps in the run a worker algorithm. Is it possible to set agent cluster's corss-origin isolated at the step 14.7 if is shared is true?

With w3c/ServiceWorker/pull/1516, we can set the property in the Run Service Worker algorithm.

That's probably okay for now, but it's not ideal. We shouldn't really create the agent cluster unless this is in order, but that matters more for implementations than the specification.

domenic · 2020-06-15T19:29:25Z

Should crossOriginIsolated be [SecureContext]?

annevk · 2020-06-26T15:12:37Z

I would be okay with the [SecureContext] restriction. I don't think Firefox currently has that, but we could add it. On the other hand it might be useful to have available always as then you don't need to check isSecureContext first.

domenic · 2020-06-26T18:28:21Z

Sorry, but I think this will need rebasing now that 0221df8 got merged. I'll try to review anyway.

I asked around internally for [SecureContext] and @arturjanc seemed slightly in favor of exposing it in non-secure contexts. I'm torn; [SecureContext] seems a bit more logical since the whole feature is restricted to secure contexts, but maybe we should make an exception for feature-detection getters. (And then there's the whole line of thinking that all new APIs should be [SecureContext], heh...)

I do think the equivalent getter for origin isolation should follow whatever pattern we choose here.

domenic · 2020-06-26T18:54:42Z

+      true.</p>
+
+      <p class="XXX">This really ought to be set when the agent cluster is created, which requires a
+      redesign of this section.</p>


It's not clear to me whether this will ever be possible. Fetches require fetch clients (ESOs). So we need to create the ESO/realm/global object before doing the fetch. And we should put all realms into agents, so we need to create the agent and its corresponding agent cluster before the fetch.

I think this is OK as-is, and we should delete the XXX. It seems similar to how various properties of the WorkerGlobalScope (and thus, the values returned by the ESO algorithms) are only set after the fetch. It's OK, as long as no code runs.

Why wouldn't it use outside settings? Note that for security reasons browsers would not be able to implement this approach as it would not properly process-isolate the worker (using a cross-origin isolated process that is).

You're right; the fetch client is outside settings. Ugh, this would be a painful redesign; we'd need to split up fetching the scripts (doable before creating the global) from creating the scripts (doable only after the global exists). Alright, this XXX should stay, I concede.

It would be particularly bad for modules, because parsing requires a realm to exist, but you need to parse before you can continue fetching dependencies. So we'd need to split it up into something like

Fetch top-level source text. (Technically all we need are the headers.... maybe stop at getting the response.)

Create the realm

Create top-level script

Fetch and create dependency scripts

Funnnnn.

A top-level navigation response with Cross-Origin-Opener-Policy set to same-origin and Cross-Origin-Embedder-Policy set to require-corp will create a cross-origin isolated browsing context group. And all agent clusters therein will be cross-origin isolated as well (shared and service workers can still not be, as they sit on the side). This change also: * Gates SharedArrayBuffer exposure behind that primitive for web compatibility reasons. * Gates SharedArrayBuffer sharing behind that primitive. * Exposes it through self.crossOriginIsolated. * Makes document.domain return before it mutates the origin. * Makes agent clusters keyed on origin. Tests: * web-platform-tests/wpt#17719 * web-platform-tests/wpt#17760 * web-platform-tests/wpt#17761 * web-platform-tests/wpt#17802 * web-platform-tests/wpt#17909 * web-platform-tests/wpt#18543 * web-platform-tests/wpt#20116 * web-platform-tests/wpt#22358 Closes #4732. Closes #5122. Closes #5444. Follow-up: #5435.

annevk · 2020-06-29T15:43:06Z

I squashed and then rebased and there were no issues. Somewhat strange. I'll work on some fixups now.

domenic

LGTM with nits, hooray

annevk · 2020-07-08T08:52:56Z

Oh wait, given the wording in tc39/ecma262#1903 I guess it's solely up to the host, not the implementation. So this is all good.

annevk added do not merge yet Pull request must not be merged per rationale in comment needs tests Moving the issue forward requires someone to write tests topic: serialize and transfer labels Jun 25, 2019

annevk commented Jun 26, 2019

View reviewed changes

Comment thread source Resolved

domenic reviewed Jul 2, 2019

View reviewed changes

Comment thread source Resolved

Comment thread source Resolved

Comment thread source Resolved

annevk mentioned this pull request Jul 9, 2019

Update SharedArrayBuffer tests to account for COOP/COEP web-platform-tests/wpt#17690

Closed

annevk commented Jul 11, 2019

View reviewed changes

Comment thread source Resolved

annevk mentioned this pull request Jul 11, 2019

COEP and cachestorage #4764

Closed

domenic reviewed Jul 11, 2019

View reviewed changes

Comment thread source Resolved

annevk mentioned this pull request Jul 11, 2019

COEP and CORP opaque responses #4767

Closed

annevk added a commit to web-platform-tests/wpt that referenced this pull request Jul 12, 2019

HTML: ensure serializing SharedArrayBuffer throws without COOP+COEP

69de2b9

For whatwg/html#4734.

annevk mentioned this pull request Jul 12, 2019

HTML: ensure serializing SharedArrayBuffer throws without COOP+COEP web-platform-tests/wpt#17802

Merged

annevk added needs tests Moving the issue forward requires someone to write tests and removed needs tests Moving the issue forward requires someone to write tests labels Jul 19, 2019

annevk added a commit to web-platform-tests/wpt that referenced this pull request Jul 19, 2019

HTML: SharedArrayBuffer infrastructure adjustments

9559f08

For whatwg/html#4734.

annevk added a commit to web-platform-tests/wpt that referenced this pull request Jul 19, 2019

HTML: SharedArrayBuffer infrastructure adjustments

581fb3e

For whatwg/html#4734.

annevk added a commit to web-platform-tests/wpt that referenced this pull request Aug 6, 2019

HTML: SharedArrayBuffer infrastructure adjustments

a140f23

For whatwg/html#4734.

annevk added a commit to web-platform-tests/wpt that referenced this pull request Aug 6, 2019

HTML: ensure serializing SharedArrayBuffer throws without COOP+COEP

aecedb5

For whatwg/html#4734.

annevk mentioned this pull request Aug 9, 2019

Remaining COOP and COEP testing work web-platform-tests/wpt#18354

Open

7 of 16 tasks

annevk commented Aug 9, 2019

View reviewed changes

Comment thread source Resolved

This comment has been minimized.

Sign in to view

annevk force-pushed the annevk/postmessage-sab branch from b465512 to c772611 Compare August 14, 2019 11:54

annevk mentioned this pull request Apr 8, 2020

Make high resolution time dependant on cross-origin isolated w3c/hr-time#89

Closed

annevk force-pushed the annevk/postmessage-sab branch from 501b094 to af6f123 Compare April 8, 2020 09:56

annevk commented Apr 8, 2020

View reviewed changes

Comment thread source Resolved

annevk commented Apr 8, 2020

View reviewed changes

moz-wptsync-bot mentioned this pull request May 28, 2020

[Gecko Bug 1601594] P2 - Changes on window-domain-success.https web-platform-tests/wpt#23821

Merged

annevk mentioned this pull request Jun 16, 2020

Add the Origin-Isolation header #5545

Merged

2 of 3 tasks

domenic mentioned this pull request Jun 26, 2020

Should the getter be [SecureContext]? WICG/origin-agent-cluster#32

Closed

domenic reviewed Jun 26, 2020

View reviewed changes

address feedback

4e5a00c

domenic approved these changes Jul 6, 2020

View reviewed changes

Comment thread source Resolved

Comment thread source Resolved

annevk and others added 2 commits July 7, 2020 12:36

getter steps

fd3f73a

More precise SAB deletion

522b16e

annevk mentioned this pull request Jul 8, 2020

SharedWorker is racy #5362

Open

nit

f1e41e5

github-actions Bot mentioned this pull request Apr 26, 2021

In JS docs, use Note: consistently at the start of notes mdn/content#4504

Merged

github-actions Bot mentioned this pull request Aug 26, 2021

Move globals (ex WindowOrWorkerGlobalScope) under API/* mdn/content#8351

Merged

github-actions Bot mentioned this pull request Jan 12, 2022

Global_Objects/SharedArrayBuffer 以下の記事を更新 mdn/translated-content#3647

Merged

github-actions Bot mentioned this pull request May 9, 2022

Initial translation for missing SharedArrayBuffer pages mdn/translated-content#5516

Merged

github-actions Bot mentioned this pull request Sep 18, 2022

Merge "SAB planned changes" into the main page mdn/content#20863

Merged

github-actions Bot mentioned this pull request Jan 3, 2023

SharedArrayBuffer の記事を更新 mdn/translated-content#10881

Merged

github-actions Bot mentioned this pull request Feb 21, 2023

JavaScript: Tag removal/status - globals s*r* mdn/content#24660

Merged

github-actions Bot mentioned this pull request Aug 3, 2023

ja: Lint front matter keys for "conflicting" mdn/translated-content#14886

Closed

github-actions Bot mentioned this pull request Aug 20, 2023

Markdownlint auto-cleanup for ja mdn/translated-content#15282

Closed

coderabbitai Bot mentioned this pull request Jul 23, 2026

fix: HRTF spatial audio worklet SatyamPandey-07/WorkSphere#1515

Merged

6 tasks done

Conversation

annevk commented Jun 25, 2019 • edited by pr-preview Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

annevk commented Jul 19, 2019

Uh oh!

This comment has been minimized.

Uh oh!

annevk Apr 8, 2020

Choose a reason for hiding this comment

yutakahirano Apr 9, 2020

Choose a reason for hiding this comment

annevk Jun 8, 2020

Choose a reason for hiding this comment

yutakahirano Jun 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

annevk Jun 8, 2020

Choose a reason for hiding this comment

domenic commented Jun 15, 2020

annevk commented Jun 26, 2020

domenic commented Jun 26, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

domenic Jun 26, 2020

Choose a reason for hiding this comment

annevk Jun 29, 2020

Choose a reason for hiding this comment

domenic Jul 6, 2020

Choose a reason for hiding this comment

domenic Jul 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

annevk commented Jun 29, 2020

domenic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

annevk commented Jul 8, 2020

Uh oh!

Labels

4 participants

annevk commented Jun 25, 2019 •

edited by pr-preview Bot

Loading

yutakahirano Jun 8, 2020 •

edited

Loading

domenic Jul 6, 2020 •

edited

Loading