Skip to content

Remove upper bound for python dependency #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nat-n
Copy link

@nat-n nat-n commented May 2, 2023

Currently this project declares that it is not compatible with python >=4.0, this sounds reasonable in that
"python 4.0" is kind of an abstract concept, but has the unfortunate side effect that any projects that do not make the same declaration cannot depend on flake8-broken-line, or any other project that depends on it!

This post elaborates better than I can on why it is a better practice to only set a lower bound for python compatibility in almost all cases: https://iscinumpy.dev/post/bound-version-constraints/

This change is required as a prerequisite of a similar change here, which in turn is required before I can upgrade rstcheck to a recent version here.

@msftcangoblowm
Copy link

^3.7 means not py37

This PR changes ^3.7 --> >=3.7.

py37 is included within >=3.7. Which is the precise version the author wants excluded.

Wouldn't the restriction become >=3.8, so py37 is excluded?

@nat-n
Copy link
Author

nat-n commented Oct 22, 2024

@msftcangoblowm According to the docs ^3.7 means >=3.7.0 and <4.0.0 (it's not a regular expression).

But anyway, this PR doesn't seem to be going anywhere, and I found a workaround, so I'll close it.

@nat-n nat-n closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants