Skip to content

Test change proposal: remove at-property-shadow.html #673

Closed
web-platform-tests/wpt-metadata
#6556

Activity

  1. emilio commented on Jul 8, 2024

    @emilio
    Author
  2. changed the title [-]Test change proposal: at-property-shadow.html[/-] on Jul 8, 2024
  3. nt1m commented on Jul 8, 2024

    @nt1m
    Member

    Would be better if we can fix it, but open to removing if we can't.

  4. andruud commented on Jul 29, 2024

    @andruud

    (I was OOO for a bit).

    Yes, please go ahead and remove it.

    Under the above circumstances, I probably would have objected to including the test in the first place.

  5. astearns commented on Jul 29, 2024

    @astearns

    It’s a good test to have, we just might need to change the expected result (as I did to match the current spec).

    I’d prefer to keep the test, open an issue on the spec, then change the test if we decide to make changes to the spec.

  6. jgraham commented on Jul 29, 2024

    @jgraham
    Contributor

    Note that the proposal is to remove the test from the interop set, not to actually delete it.

    FWIW I think if the outcome here is spec changes that lead to everyone agreeing the test is correct as-is, and therefore continuing to pass it, I doubt there'd be many objections to re-adding the test to Interop.

  7. added a commit that references this issue on Jul 30, 2024
    8e0d5ac
  8. added a commit that references this issue on Jul 30, 2024
    27d69a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    test-change-proposalProposal to add or remove tests for an interop area

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions