Skip to content

Conversation

@samthor
Copy link
Contributor

@samthor samthor commented Sep 20, 2017

  • moves *Timeline interfaces into the main externs
  • makes Animation a constructor, not an interface (i.e., we didn't allow new Animation)
  • adds id, including making AnimationEffectTimingProperties a @record so it can be extended by KeyframeAnimationOptions and used on element.animate (which returns an Animation with id).

I've also made it clear that the -next externs are just for the polyfill, and that they don't match the spec.

Plus some misc cleanups (e.g. remove opt_ from optional arguments—no longer required by Closure).

@samthor samthor requested a review from ewilligers September 20, 2017 01:36
@ewilligers ewilligers requested review from shans and removed request for ewilligers October 10, 2017 01:47
@shans
Copy link
Contributor

shans commented May 14, 2018

@samthor is this still worth looking at?

@samthor
Copy link
Contributor Author

samthor commented May 15, 2018

If the Web Animations API hasn't changed, which I don't think it has, then yes. The current version doesn't express the whole API available in Chrome, and folks using Closure might struggle.

@shans shans removed their request for review December 3, 2018 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants