Skip to content

Fix ReSpec warnings - #441

Merged
anssiko merged 1 commit into
gh-pagesfrom
fix-respec-warnings
Oct 10, 2017
Merged

Fix ReSpec warnings#441
anssiko merged 1 commit into
gh-pagesfrom
fix-respec-warnings

Conversation

@anssiko

@anssiko anssiko commented Oct 10, 2017 •
edited by pr-preview Bot
Loading

Copy link
Copy Markdown
Member

A recent ReSpec update has introduced 109 ReSpec warnings, see the top-right corner of the Editor's Draft. This PR fixes all these warnings, see the HTML preview of the spec with the following editorial fixes applied:

Global <a for> -> <a data-link-for>

Global <dfn lt> -> <dfn data-lt>

Add <dfn>presentation displays</dfn>

Add <ol data-link-for="PresentationAvailability">

Add <ol data-link-for="PresentationConnection">

Add <section data-dfn-for="Navigator" data-link-for="Navigator">

<dfn for="Navigator"><code>presentation</code></dfn> ->
<a data-link-for="Navigator"><code>presentation</code></a>

instance of the <a><code>Presentation</code></a> ->
instance of the <a data-link-for="Presentation">Presentation</a>

PTAL @mfoltzgoogle

For the record, this PR fixes the following warnings:

No <dfn> for interface Presentation. More info.
No <dfn> for interface Presentation. More info.
No <dfn> for interface Presentation. More info.
Found linkless element with text 'presentation displays' but no matching <dfn>.
Found linkless element with text 'controller' but no matching <dfn>.
Found linkless element with text 'controller' but no matching <dfn>.
Found linkless element with text 'controller' but no matching <dfn>.
Found linkless element with text 'presentation displays' but no matching <dfn>.
Found linkless element with text 'presentation displays' but no matching <dfn>.
Found linkless element with text 'start' but no matching <dfn>.
Found linkless element with text 'reconnect' but no matching <dfn>.
Found linkless element with text 'presentation connections' but no matching <dfn>.
Found linkless element with text 'controlling browsing contexts' but no matching <dfn>.
Found linkless element with text 'presentation connections' but no matching <dfn>.
Found linkless element with text 'presentation connections' but no matching <dfn>.
Found linkless element with text 'presentation connections' but no matching <dfn>.
Found linkless element with text 'presentation connections' but no matching <dfn>.
Found linkless element with text 'defaultrequest' but no matching <dfn>.
Found linkless element with text 'start' but no matching <dfn>.
Found linkless element with text 'start' but no matching <dfn>.
Found linkless element with text 'presentation identifiers' but no matching <dfn>.
Found linkless element with text 'presentation connections' but no matching <dfn>.
Found linkless element with text 'connecting' but no matching <dfn>.
Found linkless element with text 'connection' but no matching <dfn>.
Found linkless element with text 'error' but no matching <dfn>.
Found linkless element with text 'reconnect' but no matching <dfn>.
Found linkless element with text 'terminated' but no matching <dfn>.
Found linkless element with text 'connecting' but no matching <dfn>.
Found linkless element with text 'connected' but no matching <dfn>.
Found linkless element with text 'connecting' but no matching <dfn>.
Found linkless element with text 'terminated' but no matching <dfn>.
Found linkless element with text 'connecting' but no matching <dfn>.
Found linkless element with text 'connection' but no matching <dfn>.
Found linkless element with text 'start' but no matching <dfn>.
Found linkless element with text 'getavailability' but no matching <dfn>.
Found linkless element with text 'getavailability' but no matching <dfn>.
Found linkless element with text 'presentation displays' but no matching <dfn>.
Found linkless element with text 'value' but no matching <dfn>.
Found linkless element with text 'getavailability' but no matching <dfn>.
Found linkless element with text 'presentation displays' but no matching <dfn>.
Found linkless element with text 'presentation displays' but no matching <dfn>.
Found linkless element with text 'getavailability' but no matching <dfn>.
Found linkless element with text 'getavailability' but no matching <dfn>.
Found linkless element with text 'presentation displays' but no matching <dfn>.
Found linkless element with text 'presentation displays' but no matching <dfn>.
Found linkless element with text 'value' but no matching <dfn>.
Found linkless element with text 'value' but no matching <dfn>.
Found linkless element with text 'value' but no matching <dfn>.
Found linkless element with text 'value' but no matching <dfn>.
Found linkless element with text 'start' but no matching <dfn>.
Found linkless element with text 'getavailability' but no matching <dfn>.
Found linkless element with text 'presentation displays' but no matching <dfn>.
Found linkless element with text 'connection' but no matching <dfn>.
Found linkless element with text 'controller' but no matching <dfn>.
Found linkless element with text 'controller' but no matching <dfn>.
Found linkless element with text 'start' but no matching <dfn>.
Found linkless element with text 'reconnect' but no matching <dfn>.
Found linkless element with text 'defaultrequest' but no matching <dfn>.
Found linkless element with text 'connection' but no matching <dfn>.
Found linkless element with text 'connection' but no matching <dfn>.
Found linkless element with text 'reconnect' but no matching <dfn>.
Found linkless element with text 'closed' but no matching <dfn>.
Found linkless element with text 'connecting' but no matching <dfn>.
Found linkless element with text 'connected' but no matching <dfn>.
Found linkless element with text 'wentaway' but no matching <dfn>.
Found linkless element with text 'closed' but no matching <dfn>.
Found linkless element with text 'wentaway' but no matching <dfn>.
Found linkless element with text 'connecting' but no matching <dfn>.
Found linkless element with text 'connected' but no matching <dfn>.
Found linkless element with text 'error' but no matching <dfn>.
Found linkless element with text 'send' but no matching <dfn>.
Found linkless element with text 'state' but no matching <dfn>.
Found linkless element with text 'connected' but no matching <dfn>.
Found linkless element with text 'error' but no matching <dfn>.
Found linkless element with text 'state' but no matching <dfn>.
Found linkless element with text 'connected' but no matching <dfn>.
Found linkless element with text 'error' but no matching <dfn>.
Found linkless element with text 'closed' but no matching <dfn>.
Found linkless element with text 'reason' but no matching <dfn>.
Found linkless element with text 'error' but no matching <dfn>.
Found linkless element with text 'reason' but no matching <dfn>.
Found linkless element with text 'connecting' but no matching <dfn>.
Found linkless element with text 'connected' but no matching <dfn>.
Found linkless element with text 'closed' but no matching <dfn>.
Found linkless element with text 'wentaway' but no matching <dfn>.
Found linkless element with text 'connecting' but no matching <dfn>.
Found linkless element with text 'connected' but no matching <dfn>.
Found linkless element with text 'closed' but no matching <dfn>.
Found linkless element with text 'closed' but no matching <dfn>.
Found linkless element with text 'closed' but no matching <dfn>.
Found linkless element with text 'reason' but no matching <dfn>.
Found linkless element with text 'connected' but no matching <dfn>.
Found linkless element with text 'connecting' but no matching <dfn>.
Found linkless element with text 'connected' but no matching <dfn>.
Found linkless element with text 'connecting' but no matching <dfn>.
Found linkless element with text 'terminated' but no matching <dfn>.
Found linkless element with text 'connected' but no matching <dfn>.
Found linkless element with text 'terminated' but no matching <dfn>.
Found linkless element with text 'connected' but no matching <dfn>.
Found linkless element with text 'connecting' but no matching <dfn>.
Found linkless element with text 'terminated' but no matching <dfn>.
Found linkless element with text 'presentation connections' but no matching <dfn>.
Found linkless element with text 'controlling browsing contexts' but no matching <dfn>.
Found linkless element with text 'connected' but no matching <dfn>.
Found linkless element with text 'closed' but no matching <dfn>.
Found linkless element with text 'connection' but no matching <dfn>.
Found linkless element with text 'reconnect' but no matching <dfn>.
Found linkless element with text 'send' but no matching <dfn>.
Found linkless element with text 'presentation connections' but no matching <dfn>.

Preview | Diff
@anssiko
Fix ReSpec warnings
35f4aa9 
Specific changes:

Global <a for> -> <a data-link-for>

Global <dfn lt> -> <dfn data-lt>

Add <dfn>presentation displays</dfn>

Add <ol data-link-for="PresentationAvailability">

Add <ol data-link-for="PresentationConnection">

Add <section data-dfn-for="Navigator" data-link-for="Navigator">

<dfn for="Navigator"><code>presentation</code></dfn> ->
<a data-link-for="Navigator"><code>presentation</code></a>

instance of the <a><code>Presentation</code></a> ->
instance of the <a data-link-for="Presentation">Presentation</a>
@markafoltz

markafoltz commented Oct 10, 2017

Copy link
Copy Markdown
Contributor

LGTM

It doesn't bode well for this document as a living standard if ReSpec will continue to push changes that break it.
@anssiko

anssiko commented Oct 10, 2017

Copy link
Copy Markdown
Member Author

True, but to be fair, many of the warnings were caused by the use of non-standard attributes, like those fixed by data-*. I’m not expecting more such breaking changes.
@anssiko
anssiko merged commit b29f405 into gh-pages Oct 10, 2017
@anssiko
anssiko deleted the fix-respec-warnings branch October 10, 2017 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@anssiko @markafoltz