Repository navigation
[css-animations-2] setting effect should not prevent the timeline to set set via animation-timeline - #11812
Merged
graouts merged 2 commits intoMar 3, 2025
Conversation
…o bet set via `animation-timeline` While most `animation-*` CSS properties should _not_ have an effect once a `CSSAnimation` object has had its `effect` property set via the bindings, the `animation-timeline`, like the `animation-play-state` and `animation-name` properties, should not follow that pattern since it is relevant to the _animation_ and not the animation _effect_. The relevant WPT test is updated in web-platform-tests/wpt#51057.
annevk
approved these changes
Mar 3, 2025
annevk
left a comment
annevk
left a comment
Member
There was a problem hiding this comment.
Looks good modulo serial comma and missing closing apostrophe.
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
graouts
deleted the
css-animation-timeline-set-via-css-after-setting-effect
branch
March 3, 2025 15:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While most
animation-*CSS properties should not have an effect once aCSSAnimationobject has had itseffectproperty set via the bindings, theanimation-timelineproperty, like theanimation-play-stateandanimation-nameproperties, should not follow that pattern since it is relevant to the animation and not the animation effect.The relevant WPT test is updated in web-platform-tests/wpt#51057.