Skip to content

[Quantization][MoE] remove unused ep logic from moe marlin #31571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jinzhen-lin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Quantization][MoE] remove unused ep logic from moe marlin #31571

jinzhen-lin wants to merge 1 commit into from

Conversation

@jinzhen-lin
Copy link
Contributor

@jinzhen-lin jinzhen-lin commented Dec 31, 2025 •
edited
Loading

After #29642 , the ep support for moe marlin kernel is no longer required. Therefore, we can remove this dead code.
@jinzhen-lin
remove unused ep logic from moe marlin
a50eafd 
Signed-off-by: Jinzhen Lin <jinzhen.ljz@antgroup.com>
gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 31, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes unused is_ep (expert parallelism) logic from the MoE Marlin kernel. The changes are consistent across Python, C++, and CUDA files, simplifying the codebase by removing dead code. This refactoring is a good improvement for maintainability, as it makes the kernel logic more straightforward. The assumption is that expert parallelism details are now handled before the kernel is invoked, which is a sound design choice. The changes appear correct and well-executed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@jinzhen-lin