Skip to content

Use Transformers helper get_text_config() instead of checking for text_config #17105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 25, 2025

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Apr 24, 2025

Simplifies the code and makes it a little more robust (in future this helper will handle edge cases like the thinker_config in Qwen Omni (see huggingface/transformers#37517)).

…text_config`

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Apr 24, 2025
@hmellor hmellor mentioned this pull request Apr 24, 2025
5 tasks
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 24, 2025 16:47
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 24, 2025
@DarkLight1337
Copy link
Member

PTAL at failing model tests

hmellor added 2 commits April 25, 2025 10:32
…original config

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@vllm-bot vllm-bot merged commit 423e9f1 into vllm-project:main Apr 25, 2025
42 of 45 checks passed
@hmellor hmellor deleted the use-hf-helper branch April 25, 2025 15:59
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
…text_config` (vllm-project#17105)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
…text_config` (vllm-project#17105)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
…text_config` (vllm-project#17105)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
…text_config` (vllm-project#17105)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
…text_config` (vllm-project#17105)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: minpeter <kali2005611@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
3 participants
close