-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Use Transformers helper get_text_config()
instead of checking for text_config
#17105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…text_config` Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
PTAL at failing model tests |
…original config Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…text_config` (vllm-project#17105) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…text_config` (vllm-project#17105) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…text_config` (vllm-project#17105) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
…text_config` (vllm-project#17105) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
…text_config` (vllm-project#17105) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: minpeter <kali2005611@gmail.com>
Simplifies the code and makes it a little more robust (in future this helper will handle edge cases like the
thinker_config
in Qwen Omni (see huggingface/transformers#37517)).