test: Remove unnecessary dynamic timestamp from instant-validation root layouts#95105
Merged
Merged
Conversation
Contributor
Stats cancelledCommit: a8c0e7f |
Contributor
Tests PassedCommit: a8c0e7f |
This was referenced Jun 24, 2026
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
lubieowoce
force-pushed
the
lubieowoce/fix-root-layout-timestamp
branch
from
d84d9c2 to
1925d97
Compare
lubieowoce
force-pushed
the
lubieowoce/fix-root-layout-timestamp
branch
2 times, most recently
from
9158e22 to
ae43d45
Compare
unstubbable
approved these changes
Jun 24, 2026
lubieowoce
force-pushed
the
lubieowoce/fix-root-layout-timestamp
branch
from
ae43d45 to
9efe154
Compare
lubieowoce
changed the base branch from
graphite-base/95105
to
lubieowoce/partial-prefetching-reveal
This was referenced Jun 25, 2026
lubieowoce
force-pushed
the
lubieowoce/partial-prefetching-reveal
branch
from
ef835ef to
fab3063
Compare
lubieowoce
force-pushed
the
lubieowoce/fix-root-layout-timestamp
branch
2 times, most recently
from
e7d4d12 to
ff92699
Compare
lubieowoce
force-pushed
the
lubieowoce/partial-prefetching-reveal
branch
from
fab3063 to
32f8cdc
Compare
lubieowoce
force-pushed
the
lubieowoce/fix-root-layout-timestamp
branch
from
ff92699 to
a8c0e7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #94595 . The root layout includes a timestamp that we use to check if the root layout changed during a navigation, but it was unnecessarily using
await connection(); Date.now()when aperformance.now()would be enough. Changing it to not introduce a random dynamic hole which could affect validation in some way.This change revealed that some client component tests were implicitly relying on the dynamic timestamp component as a workaround for NAR-800 . I've added a workaround dynamic component to each of the relevant tests, those can be removed when we fix the bug.