[otel] Correctly set error code attributes for App API routes#94979
Merged
Conversation
Contributor
Tests PassedCommit: 4658a02 |
Contributor
Stats cancelledCommit: 4658a02 |
cb1a4e8 to
865b1f1
Compare
865b1f1 to
0f735ba
Compare
0f735ba to
921f2a8
Compare
921f2a8 to
bb1a82e
Compare
d5a1fb1 to
7669527
Compare
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
timneutkens
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

View diff without whitespace
When using adapters, throwing a JS error from a App Route Handler didn't set the OTEL status code correctly.
It was doing this:
Which I now changed to