Skip to content

Conversation

@rauchg
Copy link
Member

@rauchg rauchg commented Dec 1, 2018

@bugsnag/js works in node:

image

With ncc:

▲  ncc/ (failing-test) node src/cli.js run test/integration/bugsnag-js.js
71kB  index.js   [766ms]

/private/var/folders/bm/grflgmxs62g01cd9m8sjjm740000gn/T/fd796f4fad59e/webpack:/node_modules/@bugsnag/node/dist/bugsnag.js:1
(function(f){if(typeof exports==="object"&&typeof module!=="undefined"){module.exports=f()}else if(typeof define==="function"&&define.amd){define([],f)}else{var g;if(typeof window!=="undefined"){g=window}else if(typeof global!=="undefined"){g=global}else if(typeof self!=="undefined"){g=self}else{g=this}g.bugsnag = f()}})(function(){var define,module,exports;return (function(){function r(e,n,t){function o(i,f){if(!n[i]){if(!e[i]){var c="function"==typeof require&&require;if(!f&&c)return c(i,!0);if(u)return u(i,!0);var a=new Error("Cannot find module '"+i+"'");throw a.code="MODULE_NOT_FOUND",a}var p=n[i]={exports:{}};e[i][0].call(p.exports,function(r){var n=e[i][1][r];return o(n||r)},p,p.exports,r,e,n,t)}return n[i].exports}for(var u="function"==typeof require&&require,i=0;i<t.length;i++)o(t[i]);return o}return r})()({1:[function(require,module,exports){
^
Error: Cannot find module 'error-stack-parser'
    at o (/private/var/folders/bm/grflgmxs62g01cd9m8sjjm740000gn/T/fd796f4fad59e/webpack:/node_modules/@bugsnag/node/dist/bugsnag.js:1:1)
    at /private/var/folders/bm/grflgmxs62g01cd9m8sjjm740000gn/T/fd796f4fad59e/webpack:/node_modules/@bugsnag/node/dist/bugsnag.js:1:1
    at Object.20../lib/es-utils (/private/var/folders/bm/grflgmxs62g01cd9m8sjjm740000gn/T/fd796f4fad59e/webpack:/node_modules/@bugsnag/node/dist/bugsnag.js:1121:1)
    at o (/private/var/folders/bm/grflgmxs62g01cd9m8sjjm740000gn/T/fd796f4fad59e/webpack:/node_modules/@bugsnag/node/dist/bugsnag.js:1:1)
    at /private/var/folders/bm/grflgmxs62g01cd9m8sjjm740000gn/T/fd796f4fad59e/webpack:/node_modules/@bugsnag/node/dist/bugsnag.js:1:1
    at Object.3../breadcrumb (/private/var/folders/bm/grflgmxs62g01cd9m8sjjm740000gn/T/fd796f4fad59e/webpack:/node_modules/@bugsnag/node/dist/bugsnag.js:56:1)
    at o (/private/var/folders/bm/grflgmxs62g01cd9m8sjjm740000gn/T/fd796f4fad59e/webpack:/node_modules/@bugsnag/node/dist/bugsnag.js:1:1)
    at /private/var/folders/bm/grflgmxs62g01cd9m8sjjm740000gn/T/fd796f4fad59e/webpack:/node_modules/@bugsnag/node/dist/bugsnag.js:1:1
    at Object.24../config (/private/var/folders/bm/grflgmxs62g01cd9m8sjjm740000gn/T/fd796f4fad59e/webpack:/node_modules/@bugsnag/node/dist/bugsnag.js:1530:1)
    at o (/private/var/folders/bm/grflgmxs62g01cd9m8sjjm740000gn/T/fd796f4fad59e/webpack:/node_modules/@bugsnag/node/dist/bugsnag.js:1:1)
This was referenced Dec 3, 2018
@sokra
Copy link
Member

sokra commented Dec 3, 2018

To me it seems like this is a browserify bundle. You should be able webpack webpack bundles.

@guybedford guybedford force-pushed the failing-test branch 2 times, most recently from 1b1b65c to 76bcee5 Compare December 3, 2018 21:50
@guybedford guybedford changed the base branch from more-tests to master December 3, 2018 22:02
@guybedford
Copy link
Contributor

I switched the base back to master - will be pushing the fix up here when I've got it.

@guybedford
Copy link
Contributor

I've added the fix here for building browserify files with externals.

@guybedford
Copy link
Contributor

Fixes #91.

@codecov-io
Copy link

Codecov Report

Merging #87 into master will increase coverage by 0.95%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   73.31%   74.27%   +0.95%     
==========================================
  Files           6        6              
  Lines         356      377      +21     
==========================================
+ Hits          261      280      +19     
- Misses         95       97       +2
Impacted Files Coverage Δ
src/loaders/relocate-loader.js 92.37% <90.9%> (-0.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0c7a01...a7dad7e. Read the comment docs.

@rauchg rauchg merged commit fb8904e into master Dec 4, 2018
@rauchg rauchg deleted the failing-test branch December 4, 2018 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants