fix: track generateText usage before transform #7693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
this is based #6554 (comment)
The current approach replaces all places where result.text, response.text is used. Its very common to use these functions and replacing all is incorrect. Also it doesnt transform when the variable name is different than result or response (and other common names). So this pr tracks for
generateTextusage, gets the variable name and replaces them only. This still has issue like if same name variable is there in the file for other use too, this'll transform that too, but ig this approach is still better than prev one.Summary
I'm tracking usage of
generateText, getting the variables then transforming them.Verification
I ran the tests, all existing one are passing and added a new test to make sure it doesnt transform all. The jsshift is returning empty when no transforms are applied for me, ig its expected behaviour so the output file is kept empty
Tasks
pnpm changesetin the project root)pnpm prettier-fixin the project root)Future Work
This pr still has issue like if same name variable is there in the file for other use too, this'll transform that too, but ig this approach is still better than prev one.
Related Issues