Skip to content

Conversation

@felixblanke
Copy link
Collaborator

Addresses #90.

In sparse-matrix based wavelet decompositions, we require all transformed approximations coefficients to be of even length. This is enforced by padding a single value along all axes with odd lengths.

Currently, this is always done by zero padding. This PR adds the option to specify a different padding type.

This also makes it easier to document the padding behaviour.

@felixblanke
Copy link
Collaborator Author

I find the naming of the argument boundary of the matrix transforms very confusing, in particular as another argument of type BoundaryMode is introduced. I would therefore suggest to rename boundary to boundary_orthogonalization

@v0lta v0lta self-assigned this Jun 28, 2024
@v0lta
Copy link
Owner

v0lta commented Jun 28, 2024

Could we just call it orthogonalization instead of boundary? boundary_orthogonalization is too much to type.

@v0lta
Copy link
Owner

v0lta commented Jun 28, 2024

I have made a few changes. What do you think?

@felixblanke
Copy link
Collaborator Author

I also added the deprecation warning to the packets and added more tests

@v0lta v0lta self-requested a review June 28, 2024 18:14
Copy link
Owner

@v0lta v0lta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is ready for a merge.

@felixblanke
Copy link
Collaborator Author

I did some minor tweaks for consistency and renamed _is_boundary_mode_supported to _is_orthogonalize_method_supported.

I think this PR is good to go.

@v0lta v0lta merged commit b87482f into main Jun 30, 2024
@v0lta v0lta deleted the feature/odd-length-padding-mode branch June 30, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants