echo: handle multibyte escape sequences #6803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug was reported, with root cause analysis, by kkew3 Added tests were derived from test cases provided by kkew3 See uutils#6741
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
sylvestre
reviewed
Oct 21, 2024
sylvestre
reviewed
Oct 21, 2024
cakebaker
reviewed
Oct 21, 2024
cakebaker
reviewed
Oct 21, 2024
cakebaker
reviewed
Oct 21, 2024
cakebaker
reviewed
Oct 21, 2024
cakebaker
reviewed
Oct 21, 2024
cakebaker
reviewed
Oct 21, 2024
andrewliebenow
force-pushed
the
echo-multibyte-escape
branch
from
b1d0098 to
5b7e6a6
Compare
Contributor
Author
|
The octal/hexadecimal code ended up being a bit longer, but hopefully it's more clear now. Naming and other issues fixed. |
andrewliebenow
force-pushed
the
echo-multibyte-escape
branch
from
5b7e6a6 to
4be524a
Compare
|
GNU testsuite comparison: |
cakebaker
approved these changes
Oct 22, 2024
|
GNU testsuite comparison: |
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug was reported, with root cause analysis, by kkew3 Added tests were derived from test cases provided by kkew3 See #6741