fix(interface): drop dead reasoning-effort branches, fix stale model name and STRIX_IMAGE casing#595
Open
Rome-1 wants to merge 1 commit into
Open
fix(interface): drop dead reasoning-effort branches, fix stale model name and STRIX_IMAGE casing#595Rome-1 wants to merge 1 commit into
Rome-1 wants to merge 1 commit into
Conversation
… and STRIX_IMAGE casing Drop the two unreachable STRIX_REASONING_EFFORT branches in validate_environment (the var is never added to missing_optional_vars), replace the stale anthropic/claude-opus-4-7 example with the canonical anthropic/claude-sonnet-4-6, and correct the env-var casing in the _resolve_sandbox_image error message to STRIX_IMAGE. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Greptile SummaryThree targeted correctness fixes to user-facing interface messages in
Confidence Score: 5/5All three changes are cosmetic message fixes with no effect on runtime logic or data flow; safe to merge. The diff touches only user-facing string literals and removes provably dead elif branches. The accompanying tests are meaningful — they fail on main before the fix — and the monkeypatching pattern in the sandbox-image test correctly targets the name in the consuming module. No files require special attention. Important Files ChangedReviews (1): Last reviewed commit: "fix(interface): remove dead reasoning-ef..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small interface-message correctness fixes in
strix/interface/:validate_environment()carried twoelif var == "STRIX_REASONING_EFFORT"branches, but onlyLLM_API_KEY,LLM_API_BASE, andPERPLEXITY_API_KEYare ever appended tomissing_optional_vars, so both branches were unreachable dead code — removed.STRIX_LLMhelp text and the warm-up warning recommendedanthropic/claude-opus-4-7, a model that appears nowhere in the README or docs; switched toanthropic/claude-sonnet-4-6, the canonical recommendation used throughoutREADME.mdanddocs/._resolve_sandbox_image()reported the missing setting as lowercasestrix_image, while the actual env var / Pydantic alias isSTRIX_IMAGE; corrected the casing and now points users at bothexport STRIX_IMAGE=<image>and~/.strix/cli-config.json.Testing
pytest tests/test_interface_messages.py— 3 passed. Each test asserts one of the fixes; all three fail against currentmain(verified by reverting the source in-tree), so they are meaningful regression guards.ruff check(including pyupgradeUPrules) andbanditare clean on the changed files.mypyhook crashes with an internal error on the bundledopenaiSDK onmainas well, so it was not used as a gate here.