Skip to content

Conversation

@KKulma
Copy link
Contributor

@KKulma KKulma commented Oct 27, 2020

resolves #277

@KKulma KKulma requested a review from a team October 27, 2020 23:16
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to contribute to {pkgnet}, @KKulma ! This looks good to me, but I'll double check tonight by re-installing the package and running ?CreatePackageReport

I did notice one issue...did you notice that this commit doesn't mention your username?

image

I've had that situation before doing open source stuff. I think you should fix this before we merge, so you'll show up in the list of {pkgnet} contributors!

In case you've never seen it, I'll explain here:

It means your local git isn't configured with an email address tied to your GitHub account.
You can fix by running these commands from the root of your copy of pkgnet (substituting in your email)

git config --global user.email "whatever-email-is-tied-to-your-github@whatever.com"
git reset --soft HEAD~1
git commit -m "removed redundant colons from docs"
git push origin master --force

You'll know this worked if you go to https://github.com/uptake/pkgnet/pull/284/commits and see your username on the commit 😀

Copy link
Collaborator

@jayqi jayqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me as well.

@KKulma
Copy link
Contributor Author

KKulma commented Oct 28, 2020

git push origin master --force

hi there! Thanks so much for such a thorough commentary and a small tutorial and how to set up my git config 👍 Never paid attention to how my commits appear! Anywho, it's all fixed now and thanks again for accepting my contribution!

@jameslamb jameslamb self-requested a review October 29, 2020 05:28
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks again for taking the time to contribute here. We hope you'll come back to contribute in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants