Skip to content

Conversation

@Etherll
Copy link
Collaborator

@Etherll Etherll commented Nov 24, 2025

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Etherll, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the trust_remote_code parameter to tokenizer loading mechanisms, enhancing both the flexibility and security of the process. By allowing explicit management of remote code execution during tokenizer instantiation, this change is particularly beneficial for environments with stringent security policies or when dealing with custom tokenizer implementations.

Highlights

  • Tokenizer Configuration: The trust_remote_code parameter has been integrated into the tokenizer initialization calls within the from_pretrained function in unsloth/models/vision.py. This provides explicit control over whether remote code is trusted when loading tokenizers.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the trust_remote_code parameter to the tokenizer loading functions, ensuring the setting is propagated as intended. I've provided one suggestion to refactor a block of code to reduce duplication and improve exception handling, which will enhance maintainability.

Comment on lines 786 to 799
try:
tokenizer = auto_processor.from_pretrained(
tokenizer_name,
padding_side = "left",
token = token,
trust_remote_code = trust_remote_code,
)
except:
tokenizer = get_auto_processor(
tokenizer_name,
padding_side = "left",
token = token,
trust_remote_code = trust_remote_code,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve code clarity and reduce duplication, you can extract the common arguments for auto_processor.from_pretrained and get_auto_processor into a dictionary. This makes the code more maintainable.

Additionally, the bare except: is too broad and can catch unexpected exceptions like KeyboardInterrupt. It's better to specify the exceptions you expect to catch, or at least use except Exception:.

Suggested change
try:
tokenizer = auto_processor.from_pretrained(
tokenizer_name,
padding_side = "left",
token = token,
trust_remote_code = trust_remote_code,
)
except:
tokenizer = get_auto_processor(
tokenizer_name,
padding_side = "left",
token = token,
trust_remote_code = trust_remote_code,
)
common_kwargs = {
"padding_side": "left",
"token": token,
"trust_remote_code": trust_remote_code,
}
try:
tokenizer = auto_processor.from_pretrained(
tokenizer_name,
**common_kwargs,
)
except Exception:
tokenizer = get_auto_processor(
tokenizer_name,
**common_kwargs,
)
@danielhanchen danielhanchen merged commit a9dabc8 into unslothai:main Nov 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants