-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Add trust_remote_code parameter to tokenizer #3631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Etherll, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly adds the trust_remote_code parameter to the tokenizer loading functions, ensuring the setting is propagated as intended. I've provided one suggestion to refactor a block of code to reduce duplication and improve exception handling, which will enhance maintainability.
| try: | ||
| tokenizer = auto_processor.from_pretrained( | ||
| tokenizer_name, | ||
| padding_side = "left", | ||
| token = token, | ||
| trust_remote_code = trust_remote_code, | ||
| ) | ||
| except: | ||
| tokenizer = get_auto_processor( | ||
| tokenizer_name, | ||
| padding_side = "left", | ||
| token = token, | ||
| trust_remote_code = trust_remote_code, | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve code clarity and reduce duplication, you can extract the common arguments for auto_processor.from_pretrained and get_auto_processor into a dictionary. This makes the code more maintainable.
Additionally, the bare except: is too broad and can catch unexpected exceptions like KeyboardInterrupt. It's better to specify the exceptions you expect to catch, or at least use except Exception:.
| try: | |
| tokenizer = auto_processor.from_pretrained( | |
| tokenizer_name, | |
| padding_side = "left", | |
| token = token, | |
| trust_remote_code = trust_remote_code, | |
| ) | |
| except: | |
| tokenizer = get_auto_processor( | |
| tokenizer_name, | |
| padding_side = "left", | |
| token = token, | |
| trust_remote_code = trust_remote_code, | |
| ) | |
| common_kwargs = { | |
| "padding_side": "left", | |
| "token": token, | |
| "trust_remote_code": trust_remote_code, | |
| } | |
| try: | |
| tokenizer = auto_processor.from_pretrained( | |
| tokenizer_name, | |
| **common_kwargs, | |
| ) | |
| except Exception: | |
| tokenizer = get_auto_processor( | |
| tokenizer_name, | |
| **common_kwargs, | |
| ) |
No description provided.