-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Patch in tiled mlp #3584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+23
−3
Merged
Patch in tiled mlp #3584
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,6 +57,7 @@ | |
| # https://github.com/huggingface/transformers/pull/26037 allows 4 bit loading! | ||
| from unsloth_zoo.utils import Version, _get_dtype | ||
| from unsloth_zoo.hf_utils import dtype_from_config | ||
| from unsloth_zoo.tiled_mlp import patch_tiled_mlp | ||
|
|
||
| transformers_version = Version(transformers_version) | ||
| SUPPORTS_FOURBIT = transformers_version >= Version("4.37") | ||
|
|
@@ -566,6 +567,13 @@ def from_pretrained( | |
| ) | ||
| # Patch it as well! | ||
| model = dispatch_model.patch_peft_model(model, use_gradient_checkpointing) | ||
|
|
||
| # Patch Tiled MLP | ||
| # to turn on set UNSLOTH_TILED_MLP to "arctic", "target", or "target:{GB}"" | ||
| patch_tiled_mlp_choice = os.environ.get("UNSLOTH_TILED_MLP", "0") | ||
| if patch_tiled_mlp_choice != "0": | ||
| patch_tiled_mlp(model, patch_options_str = patch_tiled_mlp_choice) | ||
|
Comment on lines
+571
to
+575
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| return model, tokenizer | ||
|
|
||
|
|
||
|
|
@@ -1138,6 +1146,12 @@ def from_pretrained( | |
| print("Unsloth: Applying QAT to mitigate quantization degradation") | ||
| model = _prepare_model_for_qat(model, qat_scheme) | ||
|
|
||
| # Patch Tiled MLP | ||
| # to turn on set UNSLOTH_TILED_MLP to "arctic", "target", or "target:{GB}"" | ||
| patch_tiled_mlp_choice = os.environ.get("UNSLOTH_TILED_MLP", "0") | ||
| if patch_tiled_mlp_choice != "0": | ||
| patch_tiled_mlp(model, patch_options_str = patch_tiled_mlp_choice) | ||
|
Comment on lines
+1149
to
+1153
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| return model, tokenizer | ||
|
|
||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.